Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2008-01-13 Thread Stephen Rothwell
Hi Scott, On Fri, 11 Jan 2008 14:07:42 -0600 Scott Wood <[EMAIL PROTECTED]> wrote: > > +++ b/arch/powerpc/platforms/82xx/ep8248e.c > +static struct mdiobb_ops ep8248e_mdio_ops = { const, please. > +static struct of_platform_driver ep8248e_mdio_driver = { .driver = { > + .name = "e

[PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2008-01-11 Thread Scott Wood
This board is also resold by Freescale under the names "QUICCStart MPC8248 Evaluation System" and "CWH-PPC-8248N-VE". Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- arch/powerpc/boot/Makefile |3 +- arch/powerpc/boot/dts/ep8248e.dts | 205 arch/powerpc/boot/ep824

Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2008-01-02 Thread Jon Loeliger
On Fri, 2007-12-14 at 10:28, Kumar Gala wrote: > > Are there any tools to autoconvert (preferably without losing > > comments)? > > Not sure of jon had a perl script or something. No, I don't. It's hard to tell what should conceptually remain hex, and what might need to be decimalized. Sure,

Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2007-12-16 Thread Scott Wood
On Sun, Dec 16, 2007 at 05:30:20PM +1100, David Gibson wrote: > This mdio-under-bcsr arrangement is a bit strange. Can you explain > what's going on here? It's pretty much what it looks like; MDIO is connected to a couple pins that are controlled by some bits in the BCSR. -Scott

Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2007-12-15 Thread David Gibson
On Tue, Dec 11, 2007 at 03:22:47PM -0600, Scott Wood wrote: [snip] > + [EMAIL PROTECTED],0 { > + #address-cells = <2>; > + #size-cells = <1>; > + reg = <1 0 10>; > + compatible = "fsl,ep8248e-bcsr"; > +

Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2007-12-14 Thread David Gibson
On Fri, Dec 14, 2007 at 09:53:41AM -0600, Scott Wood wrote: > On Thu, Dec 13, 2007 at 11:19:33PM -0600, Kumar Gala wrote: > > Can we make this a /dts-v1/; since its new. > > It's not really new; it's just been collecting dust for a while. :-P > > Are there any tools to autoconvert (preferably wit

Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2007-12-14 Thread Scott Wood
Kumar Gala wrote: > > On Dec 14, 2007, at 9:53 AM, Scott Wood wrote: > >> On Thu, Dec 13, 2007 at 11:19:33PM -0600, Kumar Gala wrote: >>> Can we make this a /dts-v1/; since its new. >> >> It's not really new; it's just been collecting dust for a while. :-P > > Its new to us on the list :P I tho

Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2007-12-14 Thread Kumar Gala
On Dec 14, 2007, at 9:53 AM, Scott Wood wrote: > On Thu, Dec 13, 2007 at 11:19:33PM -0600, Kumar Gala wrote: >> Can we make this a /dts-v1/; since its new. > > It's not really new; it's just been collecting dust for a while. :-P Its new to us on the list :P > Are there any tools to autoconvert

Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2007-12-14 Thread Scott Wood
On Thu, Dec 13, 2007 at 11:19:33PM -0600, Kumar Gala wrote: > Can we make this a /dts-v1/; since its new. It's not really new; it's just been collecting dust for a while. :-P Are there any tools to autoconvert (preferably without losing comments)? > >+/ { > >+model = "EP8248E"; > >+compa

Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2007-12-13 Thread Kumar Gala
On Dec 11, 2007, at 3:22 PM, Scott Wood wrote: > This board is also resold by Freescale under the names > "QUICCStart MPC8248 Evaluation System" and "CWH-PPC-8248N-VE". > > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- > arch/powerpc/boot/Makefile |3 +- > arch/powerpc/boot/d

Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2007-12-12 Thread Stephen Rothwell
On Wed, 12 Dec 2007 16:48:24 -0600 Scott Wood <[EMAIL PROTECTED]> wrote: > > Stephen Rothwell wrote: > >> + ep8248e_bcsr = of_iomap(ep8248e_bcsr_node, 0); > > > > of_node_put(ep8248e_bcsr_node; > > No, because we hold on to the node for later use in ep8248e_mdio_probe(). Sorry, you are right, I

Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2007-12-12 Thread Scott Wood
Stephen Rothwell wrote: >> +ep8248e_bcsr = of_iomap(ep8248e_bcsr_node, 0); > > of_node_put(ep8248e_bcsr_node; No, because we hold on to the node for later use in ep8248e_mdio_probe(). BTW, is there any actual node removal done that justifies dealing with refcounts everywhere? -Scot ___

Re: [PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2007-12-11 Thread Stephen Rothwell
On Tue, 11 Dec 2007 15:22:47 -0600 Scott Wood <[EMAIL PROTECTED]> wrote: > > +++ b/arch/powerpc/platforms/82xx/ep8248e.c > + > +static int __devinit ep8248e_mdio_probe(struct of_device *ofdev, > +const struct of_device_id *match) > +{ > + struct mii_bus *

[PATCH 2/3] mpc82xx: Embedded Planet EP8248E support

2007-12-11 Thread Scott Wood
This board is also resold by Freescale under the names "QUICCStart MPC8248 Evaluation System" and "CWH-PPC-8248N-VE". Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- arch/powerpc/boot/Makefile |3 +- arch/powerpc/boot/dts/ep8248e.dts | 193 +++ arch/powerpc/boot/ep8248