Re: [PATCH 2/3] mpc52xx/wdt: merge WDT code into the GPT

2009-11-11 Thread Grant Likely
On Wed, Nov 11, 2009 at 1:27 AM, Albrecht Dreß wrote: > Hi Grant: > > Thanks a lot for your comments! > >> On Tue, Nov 10, 2009 at 12:41 PM, Albrecht Dreß >> > +#if defined(HAVE_MPC5200_WDT) >> > +       /* check if this device could be a watchdog */ >> > +       if (of_get_property(ofdev

Re: [PATCH 2/3] mpc52xx/wdt: merge WDT code into the GPT

2009-11-11 Thread Albrecht Dre�
Hi Grant: Thanks a lot for your comments! > On Tue, Nov 10, 2009 at 12:41 PM, Albrecht Dreß > wrote: > > Merge the WDT code into the GPT interface. > > > > Signed-off-by: Albrecht Dreß > > --- > > Hi Albrecht, > > Thanks for this work. Comments below. > > > > > Notes: > > > > The maximum

[PATCH 2/3] mpc52xx/wdt: merge WDT code into the GPT

2009-11-10 Thread Albrecht Dreß
Merge the WDT code into the GPT interface. Signed-off-by: Albrecht Dreß --- Notes: The maximum timeout for a 5200 GPT @ 33 MHz clock is ~130 seconds. As this exceeds the range of an int, some api's had to be changed to u64. The WDT api is exported as to keep the WDT driver separated from the

Re: [PATCH 2/3] mpc52xx/wdt: merge WDT code into the GPT

2009-11-10 Thread Grant Likely
On Tue, Nov 10, 2009 at 12:41 PM, Albrecht Dreß wrote: > Merge the WDT code into the GPT interface. > > Signed-off-by: Albrecht Dreß > --- Hi Albrecht, Thanks for this work. Comments below. > > Notes: > > The maximum timeout for a 5200 GPT @ 33 MHz clock is ~130 seconds.  As this > exceeds