Re: [PATCH 2/3] add MPC837x USB platform support

2008-01-07 Thread Stephen Rothwell
Hi, Just a couple of comments. On Mon, 7 Jan 2008 20:03:19 +0800 Li Yang <[EMAIL PROTECTED]> wrote: > > +static int mpc837xmds_usb_cfg(void) > +{ > > + np = of_find_node_by_name(NULL, "usb"); > + phy_type = of_get_property(np, "phy_type", NULL); No check for np being NULL > + if (p

[PATCH 2/3] add MPC837x USB platform support

2008-01-07 Thread Li Yang
Add chip specific and board specific initialization for MPC837x USB. Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- arch/powerpc/platforms/83xx/mpc837x_mds.c | 48 + arch/powerpc/platforms/83xx/mpc83xx.h |3 ++ arch/powerpc/platforms/83xx/usb.c | 39