Re: [PATCH 2/3] [POWERPC] Fix kernel stack allocation alignment

2008-04-18 Thread Benjamin Herrenschmidt
> so... the "0" defeats all of SLAB_DEBUG_FREE, SLAB_RED_ZONE, SLAB_POISON > and SLAB_STORE_USER, if the comment in slab.h is to be believed. > > Was that overkill? Well, I copied over from something else, looks like there's a -lot- of 0 users here... Shouldn't there be some kind of SLAB_DEFA

Re: [PATCH 2/3] [POWERPC] Fix kernel stack allocation alignment

2008-04-18 Thread Andrew Morton
On Fri, 18 Apr 2008 16:56:17 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > The powerpc kernel stacks need to be naturally aligned, as they > contain the thread info at the bottom, which is obtained by > clearing the low bits of the stack pointer. > > However, when using 64K pages (th

[PATCH 2/3] [POWERPC] Fix kernel stack allocation alignment

2008-04-17 Thread Benjamin Herrenschmidt
The powerpc kernel stacks need to be naturally aligned, as they contain the thread info at the bottom, which is obtained by clearing the low bits of the stack pointer. However, when using 64K pages (the stack is smaller than a page), we use kmalloc to allocate it, which doesn't provide that guaran