Re: [PATCH 2/2] selftests/ftrace: Update multiple kprobes test for powerpc

2017-06-29 Thread Naveen N. Rao
On 2017/06/29 09:57AM, Masami Hiramatsu wrote: > On Thu, 29 Jun 2017 00:13:24 +0530 > "Naveen N. Rao" wrote: > > > On 2017/06/28 11:16PM, Masami Hiramatsu wrote: > > > > > diff --git > > > > > a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_eventname.tc > > > > > b/tools/testing/selftests

Re: [PATCH 2/2] selftests/ftrace: Update multiple kprobes test for powerpc

2017-06-28 Thread Masami Hiramatsu
On Thu, 29 Jun 2017 00:13:24 +0530 "Naveen N. Rao" wrote: > On 2017/06/28 11:16PM, Masami Hiramatsu wrote: > > > > diff --git > > > > a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_eventname.tc > > > > b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_eventname.tc > > > > new file mo

Re: [PATCH 2/2] selftests/ftrace: Update multiple kprobes test for powerpc

2017-06-28 Thread Naveen N. Rao
On 2017/06/28 11:16PM, Masami Hiramatsu wrote: > > > diff --git > > > a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_eventname.tc > > > b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_eventname.tc > > > new file mode 100644 > > > index 000..d259031 > > > --- /dev/null > > > +++ b

Re: [PATCH 2/2] selftests/ftrace: Update multiple kprobes test for powerpc

2017-06-28 Thread Masami Hiramatsu
On Wed, 28 Jun 2017 14:58:46 +0530 "Naveen N. Rao" wrote: > On 2017/06/24 08:06PM, Masami Hiramatsu wrote: > > On Sat, 24 Jun 2017 02:30:21 +0900 > > Masami Hiramatsu wrote: > > > > > On Thu, 22 Jun 2017 22:33:25 +0530 > > > "Naveen N. Rao" wrote: > > > > > > > On 2017/06/22 06:07PM, Masami H

Re: [PATCH 2/2] selftests/ftrace: Update multiple kprobes test for powerpc

2017-06-28 Thread Naveen N. Rao
On 2017/06/24 08:06PM, Masami Hiramatsu wrote: > On Sat, 24 Jun 2017 02:30:21 +0900 > Masami Hiramatsu wrote: > > > On Thu, 22 Jun 2017 22:33:25 +0530 > > "Naveen N. Rao" wrote: > > > > > On 2017/06/22 06:07PM, Masami Hiramatsu wrote: > > > > On Thu, 22 Jun 2017 00:20:28 +0530 > > > > "Naveen N

Re: [PATCH 2/2] selftests/ftrace: Update multiple kprobes test for powerpc

2017-06-24 Thread Masami Hiramatsu
On Sat, 24 Jun 2017 02:30:21 +0900 Masami Hiramatsu wrote: > On Thu, 22 Jun 2017 22:33:25 +0530 > "Naveen N. Rao" wrote: > > > On 2017/06/22 06:07PM, Masami Hiramatsu wrote: > > > On Thu, 22 Jun 2017 00:20:28 +0530 > > > "Naveen N. Rao" wrote: > > > > > > > KPROBES_ON_FTRACE is only available

Re: [PATCH 2/2] selftests/ftrace: Update multiple kprobes test for powerpc

2017-06-23 Thread Masami Hiramatsu
On Thu, 22 Jun 2017 22:33:25 +0530 "Naveen N. Rao" wrote: > On 2017/06/22 06:07PM, Masami Hiramatsu wrote: > > On Thu, 22 Jun 2017 00:20:28 +0530 > > "Naveen N. Rao" wrote: > > > > > KPROBES_ON_FTRACE is only available on powerpc64le. Update comment to > > > clarify this. > > > > > > Also, we

Re: [PATCH 2/2] selftests/ftrace: Update multiple kprobes test for powerpc

2017-06-22 Thread Naveen N. Rao
On 2017/06/22 06:07PM, Masami Hiramatsu wrote: > On Thu, 22 Jun 2017 00:20:28 +0530 > "Naveen N. Rao" wrote: > > > KPROBES_ON_FTRACE is only available on powerpc64le. Update comment to > > clarify this. > > > > Also, we should use an offset of 8 to ensure that the probe does not > > fall on ftra

Re: [PATCH 2/2] selftests/ftrace: Update multiple kprobes test for powerpc

2017-06-22 Thread Masami Hiramatsu
On Thu, 22 Jun 2017 00:20:28 +0530 "Naveen N. Rao" wrote: > KPROBES_ON_FTRACE is only available on powerpc64le. Update comment to > clarify this. > > Also, we should use an offset of 8 to ensure that the probe does not > fall on ftrace location. The current offset of 4 will fall before the > fun

[PATCH 2/2] selftests/ftrace: Update multiple kprobes test for powerpc

2017-06-21 Thread Naveen N. Rao
KPROBES_ON_FTRACE is only available on powerpc64le. Update comment to clarify this. Also, we should use an offset of 8 to ensure that the probe does not fall on ftrace location. The current offset of 4 will fall before the function local entry point and won't fire, while an offset of 12 or 16 will