Re: [PATCH 2/2] powerpc/uaccess: Move might_fault() into user_access_begin()

2021-02-17 Thread Christophe Leroy
Michael Ellerman a écrit : Christophe Leroy writes: Le 08/02/2021 à 14:57, Michael Ellerman a écrit : We have a might_fault() check in __unsafe_put_user_goto(), but that is dangerous as it potentially calls lots of code while user access is enabled. It also triggers the check Alexey added t

Re: [PATCH 2/2] powerpc/uaccess: Move might_fault() into user_access_begin()

2021-02-16 Thread Michael Ellerman
Christophe Leroy writes: > Le 08/02/2021 à 14:57, Michael Ellerman a écrit : >> We have a might_fault() check in __unsafe_put_user_goto(), but that is >> dangerous as it potentially calls lots of code while user access is >> enabled. >> >> It also triggers the check Alexey added to the irq restor

Re: [PATCH 2/2] powerpc/uaccess: Move might_fault() into user_access_begin()

2021-02-12 Thread Christophe Leroy
Le 08/02/2021 à 14:57, Michael Ellerman a écrit : We have a might_fault() check in __unsafe_put_user_goto(), but that is dangerous as it potentially calls lots of code while user access is enabled. It also triggers the check Alexey added to the irq restore path to catch cases like that: W

[PATCH 2/2] powerpc/uaccess: Move might_fault() into user_access_begin()

2021-02-08 Thread Michael Ellerman
We have a might_fault() check in __unsafe_put_user_goto(), but that is dangerous as it potentially calls lots of code while user access is enabled. It also triggers the check Alexey added to the irq restore path to catch cases like that: WARNING: CPU: 30 PID: 1 at arch/powerpc/include/asm/book3