Re: [PATCH 2/2] powerpc/pseries: Check if EEH is enabled on DDW mechanism code

2016-04-06 Thread Guilherme G. Piccoli
On 02/04/2016 03:30 AM, Gavin Shan wrote: On Wed, Feb 03, 2016 at 10:26:36AM -0200, Guilherme G. Piccoli wrote: On 02/02/2016 09:48 PM, Gavin Shan wrote: Gavin, thanks very much for the clarification. So, we can interchange edev->config_addr with pdn->pci_ext_config_space ? This would solve the

Re: [PATCH 2/2] powerpc/pseries: Check if EEH is enabled on DDW mechanism code

2016-02-03 Thread Gavin Shan
On Wed, Feb 03, 2016 at 10:26:36AM -0200, Guilherme G. Piccoli wrote: >On 02/02/2016 09:48 PM, Gavin Shan wrote: >>On Tue, Jan 19, 2016 at 06:18:20PM -0200, Guilherme G. Piccoli wrote: >>>-/* only attempt to use a new window if 64-bit DMA is requested */ >>>-if (!disable_ddw && dma_mask ==

Re: [PATCH 2/2] powerpc/pseries: Check if EEH is enabled on DDW mechanism code

2016-02-03 Thread Guilherme G. Piccoli
On 02/02/2016 09:48 PM, Gavin Shan wrote: On Tue, Jan 19, 2016 at 06:18:20PM -0200, Guilherme G. Piccoli wrote: - /* only attempt to use a new window if 64-bit DMA is requested */ - if (!disable_ddw && dma_mask == DMA_BIT_MASK(64)) { + /* We should check if EEH is enabled here,

Re: [PATCH 2/2] powerpc/pseries: Check if EEH is enabled on DDW mechanism code

2016-02-02 Thread Gavin Shan
On Tue, Jan 19, 2016 at 06:18:20PM -0200, Guilherme G. Piccoli wrote: >The Dynamic DMA Window (DDW) mechanism relies on EEH to obtain the >configuration address of devices. For example, the functions query_ddw() >and create_ddw() make use of eeh_dev struct. So, the dependency is >intrinsic - DDW me

[PATCH 2/2] powerpc/pseries: Check if EEH is enabled on DDW mechanism code

2016-01-19 Thread Guilherme G. Piccoli
The Dynamic DMA Window (DDW) mechanism relies on EEH to obtain the configuration address of devices. For example, the functions query_ddw() and create_ddw() make use of eeh_dev struct. So, the dependency is intrinsic - DDW mechanism will fail if EEH is not enabled. Despite this dependency, no chec