Re: [PATCH 2/2] powerpc/powernv: Remove duplicate check in tce_iommu_bus_notifier()

2014-08-11 Thread Gavin Shan
On Mon, Aug 11, 2014 at 01:11:58PM +1000, Benjamin Herrenschmidt wrote: >On Wed, 2014-08-06 at 17:10 +1000, Gavin Shan wrote: >> The called function iommu_del_device() checks if the device has >> attached IOMMU group, we needn't check it again in the parent >> function call tce_iommu_bus_notifier()

Re: [PATCH 2/2] powerpc/powernv: Remove duplicate check in tce_iommu_bus_notifier()

2014-08-10 Thread Benjamin Herrenschmidt
On Wed, 2014-08-06 at 17:10 +1000, Gavin Shan wrote: > The called function iommu_del_device() checks if the device has > attached IOMMU group, we needn't check it again in the parent > function call tce_iommu_bus_notifier(). The patch does more than that... it also refactors the function, which it

[PATCH 2/2] powerpc/powernv: Remove duplicate check in tce_iommu_bus_notifier()

2014-08-06 Thread Gavin Shan
The called function iommu_del_device() checks if the device has attached IOMMU group, we needn't check it again in the parent function call tce_iommu_bus_notifier(). Signed-off-by: Gavin Shan --- arch/powerpc/platforms/powernv/pci.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletion