Re: [PATCH 2/2] powerpc/64s: __find_linux_pte synchronization vs pmdp_invalidate

2019-06-11 Thread Michael Ellerman
On Fri, 2019-06-07 at 03:56:36 UTC, Nicholas Piggin wrote: > The change to pmdp_invalidate to mark the pmd with _PAGE_INVALID broke > the synchronisation against lock free lookups, __find_linux_pte's > pmd_none check no longer returns true for such cases. > > Fix this by adding a check for this co

Re: [PATCH 2/2] powerpc/64s: __find_linux_pte synchronization vs pmdp_invalidate

2019-06-06 Thread Nicholas Piggin
Christophe Leroy's on June 7, 2019 3:35 pm: > > > Le 07/06/2019 à 05:56, Nicholas Piggin a écrit : >> The change to pmdp_invalidate to mark the pmd with _PAGE_INVALID broke >> the synchronisation against lock free lookups, __find_linux_pte's >> pmd_none check no longer returns true for such cases

Re: [PATCH 2/2] powerpc/64s: __find_linux_pte synchronization vs pmdp_invalidate

2019-06-06 Thread Aneesh Kumar K.V
Nicholas Piggin writes: > The change to pmdp_invalidate to mark the pmd with _PAGE_INVALID broke > the synchronisation against lock free lookups, __find_linux_pte's > pmd_none check no longer returns true for such cases. > > Fix this by adding a check for this condition as well. > Reviewed-by: A

Re: [PATCH 2/2] powerpc/64s: __find_linux_pte synchronization vs pmdp_invalidate

2019-06-06 Thread Christophe Leroy
Le 07/06/2019 à 05:56, Nicholas Piggin a écrit : The change to pmdp_invalidate to mark the pmd with _PAGE_INVALID broke the synchronisation against lock free lookups, __find_linux_pte's pmd_none check no longer returns true for such cases. Fix this by adding a check for this condition as well

[PATCH 2/2] powerpc/64s: __find_linux_pte synchronization vs pmdp_invalidate

2019-06-06 Thread Nicholas Piggin
The change to pmdp_invalidate to mark the pmd with _PAGE_INVALID broke the synchronisation against lock free lookups, __find_linux_pte's pmd_none check no longer returns true for such cases. Fix this by adding a check for this condition as well. Fixes: da7ad366b497 ("powerpc/mm/book3s: Update pmd