Re: [PATCH 2/2] powerpc/64: Increase stack redzone for 64-bit kernel to 512 bytes

2018-10-02 Thread Segher Boessenkool
On Tue, Oct 02, 2018 at 09:59:29AM +1000, Nicholas Piggin wrote: > On Mon, 1 Oct 2018 03:51:21 -0500 > Segher Boessenkool wrote: > > And that is required by the ABI! > > > > """ > > 2.2.2.4. Protected Zone > > > > The 288 bytes below the stack pointer are available as volatile program > > storag

Re: [PATCH 2/2] powerpc/64: Increase stack redzone for 64-bit kernel to 512 bytes

2018-10-01 Thread Nicholas Piggin
On Mon, 1 Oct 2018 20:41:19 +0800 Bin Meng wrote: > Hi Nick, > > On Mon, Oct 1, 2018 at 10:23 AM Nicholas Piggin wrote: > > > > On Mon, 1 Oct 2018 09:11:04 +0800 > > Bin Meng wrote: > > > > > Hi Nick, > > > > > > On Mon, Oct 1, 2018 at 7:27 AM Nicholas Piggin wrote: > > > > > > > > > > >

Re: [PATCH 2/2] powerpc/64: Increase stack redzone for 64-bit kernel to 512 bytes

2018-10-01 Thread Nicholas Piggin
On Mon, 1 Oct 2018 03:51:21 -0500 Segher Boessenkool wrote: > Hi! > > On Mon, Oct 01, 2018 at 12:22:56PM +1000, Nicholas Piggin wrote: > > On Mon, 1 Oct 2018 09:11:04 +0800 > > Bin Meng wrote: > > > On Mon, Oct 1, 2018 at 7:27 AM Nicholas Piggin wrote: > > > > > > > On Sat, 29 Sep 2018 23

Re: [PATCH 2/2] powerpc/64: Increase stack redzone for 64-bit kernel to 512 bytes

2018-10-01 Thread Bin Meng
Hi Nick, On Mon, Oct 1, 2018 at 10:23 AM Nicholas Piggin wrote: > > On Mon, 1 Oct 2018 09:11:04 +0800 > Bin Meng wrote: > > > Hi Nick, > > > > On Mon, Oct 1, 2018 at 7:27 AM Nicholas Piggin wrote: > > > > > > On Sat, 29 Sep 2018 23:25:20 -0700 > > > Bin Meng wrote: > > > > > > > commit 573ebfa

Re: [PATCH 2/2] powerpc/64: Increase stack redzone for 64-bit kernel to 512 bytes

2018-10-01 Thread Segher Boessenkool
On Sat, Sep 29, 2018 at 11:25:20PM -0700, Bin Meng wrote: > /* > - * Size of redzone that userspace is allowed to use below the stack > + * Size of redzone that kernel/userspace is allowed to use below the stack > * pointer. This is 288 in the 64-bit big-endian ELF ABI, and 512 in > * the new

Re: [PATCH 2/2] powerpc/64: Increase stack redzone for 64-bit kernel to 512 bytes

2018-10-01 Thread Segher Boessenkool
Hi! On Mon, Oct 01, 2018 at 12:22:56PM +1000, Nicholas Piggin wrote: > On Mon, 1 Oct 2018 09:11:04 +0800 > Bin Meng wrote: > > On Mon, Oct 1, 2018 at 7:27 AM Nicholas Piggin wrote: > > > On Sat, 29 Sep 2018 23:25:20 -0700 > > > Bin Meng wrote: > > > > commit 573ebfa6601f ("powerpc: Increase sta

Re: [PATCH 2/2] powerpc/64: Increase stack redzone for 64-bit kernel to 512 bytes

2018-09-30 Thread Nicholas Piggin
On Mon, 1 Oct 2018 09:11:04 +0800 Bin Meng wrote: > Hi Nick, > > On Mon, Oct 1, 2018 at 7:27 AM Nicholas Piggin wrote: > > > > On Sat, 29 Sep 2018 23:25:20 -0700 > > Bin Meng wrote: > > > > > commit 573ebfa6601f ("powerpc: Increase stack redzone for 64-bit > > > userspace to 512 bytes") only

Re: [PATCH 2/2] powerpc/64: Increase stack redzone for 64-bit kernel to 512 bytes

2018-09-30 Thread Bin Meng
Hi Nick, On Mon, Oct 1, 2018 at 7:27 AM Nicholas Piggin wrote: > > On Sat, 29 Sep 2018 23:25:20 -0700 > Bin Meng wrote: > > > commit 573ebfa6601f ("powerpc: Increase stack redzone for 64-bit > > userspace to 512 bytes") only changes stack userspace redzone size. > > We need increase the kernel o

Re: [PATCH 2/2] powerpc/64: Increase stack redzone for 64-bit kernel to 512 bytes

2018-09-30 Thread Nicholas Piggin
On Sat, 29 Sep 2018 23:25:20 -0700 Bin Meng wrote: > commit 573ebfa6601f ("powerpc: Increase stack redzone for 64-bit > userspace to 512 bytes") only changes stack userspace redzone size. > We need increase the kernel one to 512 bytes too per ABIv2 spec. You're right we need 512 to be compatible

[PATCH 2/2] powerpc/64: Increase stack redzone for 64-bit kernel to 512 bytes

2018-09-29 Thread Bin Meng
commit 573ebfa6601f ("powerpc: Increase stack redzone for 64-bit userspace to 512 bytes") only changes stack userspace redzone size. We need increase the kernel one to 512 bytes too per ABIv2 spec. Signed-off-by: Bin Meng --- arch/powerpc/include/asm/ptrace.h | 8 ++-- 1 file changed, 2 ins