Re: [PATCH 2/2] maps/mtd-ram: add an of-platform driver

2009-05-20 Thread Grant Likely
On Wed, May 20, 2009 at 6:46 PM, Wolfram Sang wrote: >> > +       name = of_get_property(op->node, "name", NULL); >> > +       if (!name) { >> > +               ret = -ENOENT; >> > +               dev_dbg(&op->dev, "could not get node name\n"); >> > +               goto bad1; >> > +       } > > Ca

Re: [PATCH 2/2] maps/mtd-ram: add an of-platform driver

2009-05-20 Thread Wolfram Sang
Hello Grant, as I am just working on V2 (fixed even some additional things), two more questions came up: On Tue, May 19, 2009 at 08:57:15AM -0600, Grant Likely wrote: > On Wed, Jan 21, 2009 at 11:41 AM, Wolfram Sang wrote: > > Create an of-aware driver using the now exported generic functions fr

Re: [PATCH 2/2] maps/mtd-ram: add an of-platform driver

2009-05-19 Thread Grant Likely
On Tue, May 19, 2009 at 2:30 PM, Wolfram Sang wrote: >> This name is too generic for an of_platform device.  'mtd' needs to be >> in there somewhere. > > Will "of-mtd-ram" do? (I'd think so) fine by me. g -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _

Re: [PATCH 2/2] maps/mtd-ram: add an of-platform driver

2009-05-19 Thread Wolfram Sang
Hi Grant, thanks a lot for the review! On Tue, May 19, 2009 at 08:57:15AM -0600, Grant Likely wrote: > On Wed, Jan 21, 2009 at 11:41 AM, Wolfram Sang wrote: > > Create an of-aware driver using the now exported generic functions from > > plat-ram.c. A typical oftree snipplet for it looks like thi

Re: [PATCH 2/2] maps/mtd-ram: add an of-platform driver

2009-05-19 Thread Grant Likely
On Wed, Jan 21, 2009 at 11:41 AM, Wolfram Sang wrote: > Create an of-aware driver using the now exported generic functions from > plat-ram.c. A typical oftree snipplet for it looks like this: > > s...@04e0 { >        compatible = "mtd-ram"; >        reg = <0x04e0 0x0020>; >        bank

Re: [PATCH 2/2] maps/mtd-ram: add an of-platform driver

2009-01-24 Thread Wolfram Sang
Hello, found one question thing myself... On Wed, Jan 21, 2009 at 06:41:25PM +0100, Wolfram Sang wrote: > Create an of-aware driver using the now exported generic functions from > plat-ram.c. A typical oftree snipplet for it looks like this: > > s...@04e0 { > compatible = "mtd-ram"; >

[PATCH 2/2] maps/mtd-ram: add an of-platform driver

2009-01-21 Thread Wolfram Sang
Create an of-aware driver using the now exported generic functions from plat-ram.c. A typical oftree snipplet for it looks like this: s...@04e0 { compatible = "mtd-ram"; reg = <0x04e0 0x0020>; bank-width = <2>; }; Partitions on this device are not yet supported