Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Jean Delvare
Hi Sean, On Tue, 19 Feb 2008 16:58:01 -0500, Sean MacLennan wrote: > Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> > > --- for-2.6.25/drivers/i2c/busses/orig-i2c-ibm_iic.c 2008-02-18 > 16:36:30.0 -0500 > +++ for-2.6.25/drivers/i2c/busses/i2c-ibm_iic.c 2008-02-19 > 16:46:35.00

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Jean Delvare
Hi Arnd, On Tue, 19 Feb 2008 23:55:16 +0100, Arnd Bergmann wrote: > On Tuesday 19 February 2008, Stefan Roese wrote: > > On Tuesday 19 February 2008, Jean Delvare wrote: > > > > > > With this Kconfig change, "make menuconfig" lets me select the > > > i2c-ibm_iic driver on x86_64, but it fails to b

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Arnd Bergmann
On Wednesday 20 February 2008, Stephen Rothwell wrote: > > > -       depends on IBM_OCP > > > +       depends on IBM_OCP || PPC_MERGE > > not PPC_OF?  or even OF (give the sparc guys the opportunity to build it > for us :-))? > Right, I was looking for that option but couldn't find it. I would g

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Stephen Rothwell
> > - depends on IBM_OCP > > + depends on IBM_OCP || PPC_MERGE not PPC_OF? or even OF (give the sparc guys the opportunity to build it for us :-))? -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ pgpCiK7cr2CGX.pgp Description: PGP

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Sean MacLennan
Arnd Bergmann wrote: > On Tuesday 19 February 2008, Stefan Roese wrote: > >> On Tuesday 19 February 2008, Jean Delvare wrote: >> >>> With this Kconfig change, "make menuconfig" lets me select the >>> i2c-ibm_iic driver on x86_64, but it fails to build horribly. I think >>> that you want to

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Arnd Bergmann
On Tuesday 19 February 2008, Stefan Roese wrote: > On Tuesday 19 February 2008, Jean Delvare wrote: > > > > With this Kconfig change, "make menuconfig" lets me select the > > i2c-ibm_iic driver on x86_64, but it fails to build horribly. I think > > that you want to restrict the build to PPC machine

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Sean MacLennan
Stefan Roese wrote: > How about this: > > - depends on IBM_OCP > + depends on 4xx > That's what I did, great minds think alike ;) But the email does not seem to have come through, so I will repost the patch. If you already got an email with the above patch, you can ignore this one ;)

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Sean MacLennan
Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> --- for-2.6.25/drivers/i2c/busses/orig-i2c-ibm_iic.c2008-02-18 16:36:30.0 -0500 +++ for-2.6.25/drivers/i2c/busses/i2c-ibm_iic.c 2008-02-19 16:46:35.0 -0500 @@ -6,6 +6,9 @@ * Copyright (c) 2003, 2004 Zultys Technologies. *

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Stefan Roese
On Tuesday 19 February 2008, Jean Delvare wrote: > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > > index b61f56b..44c0984 100644 > > --- a/drivers/i2c/busses/Kconfig > > +++ b/drivers/i2c/busses/Kconfig > > @@ -244,7 +244,6 @@ config I2C_PIIX4 > > > > config I2C_IBM_IIC

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Jean Delvare
Hi Sean, On Mon, 18 Feb 2008 20:42:46 -0500, Sean MacLennan wrote: > An updated version of the patch. This one should answer all of Jean's > concerns. > > Cheers, >Sean > > Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> > --- > --- for-2.6.25/drivers/i2c/busses/orig-i2c-ibm_iic.c 2008-0

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-18 Thread Sean MacLennan
An updated version of the patch. This one should answer all of Jean's concerns. Cheers, Sean Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> --- --- for-2.6.25/drivers/i2c/busses/orig-i2c-ibm_iic.c2008-02-18 16:36:30.0 -0500 +++ for-2.6.25/drivers/i2c/busses/i2c-ibm_iic.c 2008-

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-17 Thread Jean Delvare
Hi Sean, On Sat, 16 Feb 2008 15:54:14 -0500, Sean MacLennan wrote: > Jean Delvare wrote: > > Hi Sean, > > > > On Fri, 15 Feb 2008 23:11:12 -0500, Sean MacLennan wrote: > > > >> Here is the of platform patch. I removed the retries and removed the > >> spaces used for spacing. > >> > >> Cheers,

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-16 Thread Sean MacLennan
Jean Delvare wrote: > Hi Sean, > > On Fri, 15 Feb 2008 23:11:12 -0500, Sean MacLennan wrote: > >> Here is the of platform patch. I removed the retries and removed the spaces >> used for spacing. >> >> Cheers, >>Sean >> >> Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> >> > > First o

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-16 Thread Jean Delvare
Hi Sean, On Fri, 15 Feb 2008 23:11:12 -0500, Sean MacLennan wrote: > Here is the of platform patch. I removed the retries and removed the spaces > used for spacing. > > Cheers, >Sean > > Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> First of all: please run scripts/checkpatch.pl on you

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-15 Thread Sean MacLennan
Here is the of platform patch. I removed the retries and removed the spaces used for spacing. Cheers, Sean Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> --- --- old-i2c-ibm_iic.c 2008-02-15 23:01:58.0 -0500 +++ i2c-ibm_iic.c 2008-02-15 23:00:44.0 -0500 @@ -6,6 +6,9