Re: [PATCH 2/2] clk for mpc52xx: use psc_mclk's in spi driver

2007-10-14 Thread Domen Puncer
On 14/10/07 16:42 -0600, Grant Likely wrote: > On 10/14/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > > Use clocks subsystem in spi driver. > > I don't understand the advantage of this approach. Is the current code > broken? Actually the calculations are broken. But ok, fix doesn't need to be l

Re: [PATCH 2/2] clk for mpc52xx: use psc_mclk's in spi driver

2007-10-14 Thread Grant Likely
On 10/14/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > Use clocks subsystem in spi driver. I don't understand the advantage of this approach. Is the current code broken? I agree that abstraction is good; but in this case it seems these two patches add a lot of code for a very simple calculation.

[PATCH 2/2] clk for mpc52xx: use psc_mclk's in spi driver

2007-10-14 Thread Domen Puncer
Use clocks subsystem in spi driver. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- drivers/spi/mpc52xx_psc_spi.c | 64 +- 1 files changed, 57 insertions(+), 7 deletions(-) Index: linux.git/drivers/spi/mpc52xx_psc_spi.c