Re: [PATCH 2/2] Add cpufreq driver for Momentum Maple boards

2011-06-30 Thread Dave Jones
On Thu, Jun 30, 2011 at 01:23:03PM -0500, kevin diggs wrote: > Hi, > > On Wed, Jun 29, 2011 at 3:58 PM, Dmitry Eremin-Solenikov > wrote: > > > > drivers/cpufreq/powerpc. However my current version (as suggested by Ben) > > goes directly to drivers/cpufreq > > > Uh ... Just curious ... wh

Re: [PATCH 2/2] Add cpufreq driver for Momentum Maple boards

2011-06-30 Thread kevin diggs
Hi, On Wed, Jun 29, 2011 at 3:58 PM, Dmitry Eremin-Solenikov wrote: > > drivers/cpufreq/powerpc. However my current version (as suggested by Ben) > goes directly to drivers/cpufreq > Uh ... Just curious ... why is arch specific code now being put outside of the arch directories? When I wrote the

Re: [PATCH 2/2] Add cpufreq driver for Momentum Maple boards

2011-06-29 Thread Dmitry Eremin-Solenikov
On Wed, Jun 29, 2011 at 10:09 PM, kevin diggs wrote: > Hi, > > On Tue, Jun 28, 2011 at 10:28 PM, Benjamin Herrenschmidt > >> >> If we're going to have a Kconfig.powerpc, should we maybe just have a >> powerpc subdirectory instead with the driver in it ? >> > Where would the powerpc subdirectory be

Re: [PATCH 2/2] Add cpufreq driver for Momentum Maple boards

2011-06-29 Thread kevin diggs
Hi, Try this one more time ... On Wed, Jun 29, 2011 at 3:54 AM, Benjamin Herrenschmidt wrote: > On Wed, 2011-06-29 at 12:40 +0400, Dmitry Eremin-Solenikov wrote: > > If you feel like it :-) The powermac one has quite a bit more plumbing > for voltage control etc... but it does make sense in the

Re: [PATCH 2/2] Add cpufreq driver for Momentum Maple boards

2011-06-29 Thread kevin diggs
Hi, On Tue, Jun 28, 2011 at 10:28 PM, Benjamin Herrenschmidt > > > If we're going to have a Kconfig.powerpc, should we maybe just have a > powerpc subdirectory instead with the driver in it ? > Where would the powerpc subdirectory be? under drivers/cpufreq? Or somewhere under arch/powerpc where it

Re: [PATCH 2/2] Add cpufreq driver for Momentum Maple boards

2011-06-29 Thread Benjamin Herrenschmidt
On Wed, 2011-06-29 at 12:40 +0400, Dmitry Eremin-Solenikov wrote: > On 6/29/11, Benjamin Herrenschmidt wrote: > > Before I comment on this last one, a quick Q. for Dave: Do you want to > > handle this or should I merge it via powerpc.git ? (It depends on > > another change to the arch code to expo

Re: [PATCH 2/2] Add cpufreq driver for Momentum Maple boards

2011-06-29 Thread Dmitry Eremin-Solenikov
On 6/29/11, Benjamin Herrenschmidt wrote: > Before I comment on this last one, a quick Q. for Dave: Do you want to > handle this or should I merge it via powerpc.git ? (It depends on > another change to the arch code to expose the SCOM functions that it > uses, and that patch is going to be in my

Re: [PATCH 2/2] Add cpufreq driver for Momentum Maple boards

2011-06-28 Thread Dave Jones
On Wed, Jun 29, 2011 at 01:28:30PM +1000, Ben Herrenschmidt wrote: > Before I comment on this last one, a quick Q. for Dave: Do you want to > handle this or should I merge it via powerpc.git ? (It depends on > another change to the arch code to expose the SCOM functions that it > uses, and that

Re: [PATCH 2/2] Add cpufreq driver for Momentum Maple boards

2011-06-28 Thread Benjamin Herrenschmidt
Before I comment on this last one, a quick Q. for Dave: Do you want to handle this or should I merge it via powerpc.git ? (It depends on another change to the arch code to expose the SCOM functions that it uses, and that patch is going to be in my -next branch). Now some remaining small nits: On

[PATCH 2/2] Add cpufreq driver for Momentum Maple boards

2011-06-17 Thread Dmitry Eremin-Solenikov
Add simple cpufreq driver for Maple-based boards (ppc970fx evaluation kit and others). Driver is based on a cpufreq driver for 64-bit powermac boxes with all pmac-dependant features removed and simple cleanup applied. Signed-off-by: Dmitry Eremin-Solenikov --- drivers/cpufreq/Kconfig |