Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-08-06 Thread Segher Boessenkool
>> The hardware is called (E)IDE, the protocol is called ATA. >> Or that's what I was told -- I think there's some historic >> revisionism involved, too. > > ATA is the interface and standards for the ANSI standards based disk > attachment. IDE "Integrated Drive Electronics" is a marketing name use

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-08-01 Thread Sergei Shtylyov
Hello. Segher Boessenkool wrote: +[EMAIL PROTECTED] { +compatible = "mmio-ide"; +device_type = "ide"; >>> Why not "ata"? > The hardware is called (E)IDE, the protocol is called ATA. Sorry for not denouncing this earlier. :-) ATA is the name of ANS

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-31 Thread Alan Cox
> The hardware is called (E)IDE, the protocol is called ATA. > Or that's what I was told -- I think there's some historic > revisionism involved, too. ATA is the interface and standards for the ANSI standards based disk attachment. IDE "Integrated Drive Electronics" is a marketing name used to cov

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-31 Thread Segher Boessenkool
>>I never suggested that -- what I did suggest was make of_serial.c >> recognize certain chip types and register them with 8250 driver. > > What would be the advantage of maintaining a list of chips whose only > difference is register spacing, rather than just using reg-shift and > being done w

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-31 Thread Segher Boessenkool
>>> + [EMAIL PROTECTED] { >>> + compatible = "mmio-ide"; >>> + device_type = "ide"; > >> Why not "ata"? The hardware is called (E)IDE, the protocol is called ATA. Or that's what I was told -- I think there's some historic revisionism involved, too. > Also, what mmio-

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Sergei Shtylyov
Hello. Vitaly Bordug wrote: >>> I acn undertand your complaint in the context of an OF driver >>>(which we don't have yet) but "mmio-ide" just means nothing to the >>>current driver, and it doesn't convery enough info on the >>>programming interface for the conceivable OF driver, it also does >

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Vitaly Bordug
On Wed, 25 Jul 2007 13:46:57 -0500 Scott Wood wrote: > Sergei Shtylyov wrote: > >I acn undertand your complaint in the context of an OF driver > > (which we don't have yet) but "mmio-ide" just means nothing to the > > current driver, and it doesn't convery enough info on the > > programming in

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Vitaly Bordug
On Wed, 25 Jul 2007 21:06:42 +0400 Sergei Shtylyov wrote: > Hello. > > Vitaly Bordug wrote: > > > This updates relevant platform code (freescale mpc8349itx target) > > to make the CompactFlash work in TrueIDE mode. > >Erm, I'm not sure it's worth submitting the platform device driver > fo

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Sergei Shtylyov
Hello, I wrote: > Also, what mmio-ide in the compat properly means in the context >of ide_platform which is able to handle both port and memory mapped >IDE. I/O-space is only valid in the context of PCI, ISA, or similar buses, and the bus-specific reg format indicates

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Sergei Shtylyov
Scott Wood wrote: >> Scott Wood wrote: Also, what mmio-ide in the compat properly means in the context of ide_platform which is able to handle both port and memory mapped IDE. >>> I/O-space is only valid in the context of PCI, ISA, or similar buses, >>> and >>> the bus-speci

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Scott Wood
Sergei Shtylyov wrote: >I acn undertand your complaint in the context of an OF driver (which > we don't have yet) but "mmio-ide" just means nothing to the current > driver, and it doesn't convery enough info on the programming interface > for the conceivable OF driver, it also does need to k

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Scott Wood
Sergei Shtylyov wrote: > Hello. > > Scott Wood wrote: > >>>Also, what mmio-ide in the compat properly means in the context of >>> ide_platform which is able to handle both port and memory mapped IDE. > > >> I/O-space is only valid in the context of PCI, ISA, or similar buses, and >> the bu

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Sergei Shtylyov
Scott Wood wrote: >>Also, what mmio-ide in the compat properly means in the context of >>ide_platform which is able to handle both port and memory mapped IDE. >>I think we must get rid with this crap, and since this IDE register >>mapping is pretty much board specific, call it something like

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Sergei Shtylyov
Hello. Scott Wood wrote: >>Also, what mmio-ide in the compat properly means in the context of >>ide_platform which is able to handle both port and memory mapped IDE. > I/O-space is only valid in the context of PCI, ISA, or similar buses, and > the bus-specific reg format indicates whether i

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Scott Wood
On Wed, Jul 25, 2007 at 09:54:07PM +0400, Sergei Shtylyov wrote: > Also, what mmio-ide in the compat properly means in the context of > ide_platform which is able to handle both port and memory mapped IDE. I/O-space is only valid in the context of PCI, ISA, or similar buses, and the bus-speci

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Sergei Shtylyov
Hello, I wrote: >>diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts >>b/arch/powerpc/boot/dts/mpc8349emitx.dts >>index db0d003..f8f0e8a 100644 >>--- a/arch/powerpc/boot/dts/mpc8349emitx.dts >>+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts >>@@ -37,6 +37,15 @@ >> reg = < 1

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Scott Wood
Vitaly Bordug wrote: > diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts > b/arch/powerpc/boot/dts/mpc8349emitx.dts > index db0d003..f8f0e8a 100644 > --- a/arch/powerpc/boot/dts/mpc8349emitx.dts > +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts > @@ -37,6 +37,15 @@ > reg = < 1

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Sergei Shtylyov
Hello. Vitaly Bordug wrote: > This updates relevant platform code (freescale mpc8349itx target) > to make the CompactFlash work in TrueIDE mode. Erm, I'm not sure it's worth submitting the platform device driver for PowerPC at this point, but well... > Signed-off-by: Anton Vorontsov <[EMA

[PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Vitaly Bordug
This updates relevant platform code (freescale mpc8349itx target) to make the CompactFlash work in TrueIDE mode. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8349emitx.dts|9 arch/powerpc/platfor