Re: [PATCH 13/28] 8xx: Infrastructure code cleanup.

2007-09-18 Thread Scott Wood
On Wed, Sep 19, 2007 at 02:25:33PM +1000, David Gibson wrote: > On Mon, Sep 17, 2007 at 11:57:42AM -0500, Scott Wood wrote: > > 1. Keep a global mpc8xx_immr mapping, rather than constantly > > creating temporary mappings. > > Nice, but again, it seems a bit pointless to leave in all the > immr_map

Re: [PATCH 13/28] 8xx: Infrastructure code cleanup.

2007-09-18 Thread David Gibson
On Mon, Sep 17, 2007 at 11:57:42AM -0500, Scott Wood wrote: > 1. Keep a global mpc8xx_immr mapping, rather than constantly > creating temporary mappings. Nice, but again, it seems a bit pointless to leave in all the immr_map() / immr_unmap() pairs now that they do basically nothing. -- David Gib

[PATCH 13/28] 8xx: Infrastructure code cleanup.

2007-09-17 Thread Scott Wood
1. Keep a global mpc8xx_immr mapping, rather than constantly creating temporary mappings. 2. Look for new fsl,cpm1 and fsl,cpm1-pic names. 3. Always reset the CPM when not using the udbg console; this is required in case the firmware initialized a device that is incompatible with one that the kerne