Re: [PATCH 12/24] powerpc/mm: Fix reporting of kernel execute faults

2018-11-29 Thread Christophe LEROY
Le 30/11/2018 à 06:50, Aneesh Kumar K.V a écrit : Christophe LEROY writes: Hi Ben, I have an issue on the 8xx with this change Le 19/07/2017 à 06:49, Benjamin Herrenschmidt a écrit : We currently test for is_exec and DSISR_PROTFAULT but that doesn't make sense as this is the wrong error

Re: [PATCH 12/24] powerpc/mm: Fix reporting of kernel execute faults

2018-11-07 Thread Benjamin Herrenschmidt
On Wed, 2018-11-07 at 09:35 +0100, Christophe LEROY wrote: > Hi Ben, > > I have an issue on the 8xx with this change Ah ouch... .../... > > +/* Is this a bad kernel fault ? */ > > +static bool bad_kernel_fault(bool is_exec, unsigned long error_code, > > +unsigned long

Re: [PATCH 12/24] powerpc/mm: Fix reporting of kernel execute faults

2018-11-07 Thread Christophe LEROY
Hi Ben, I have an issue on the 8xx with this change Le 19/07/2017 à 06:49, Benjamin Herrenschmidt a écrit : We currently test for is_exec and DSISR_PROTFAULT but that doesn't make sense as this is the wrong error bit to test for an execute permission failure. On the 8xx, on an exec permission

[PATCH 12/24] powerpc/mm: Fix reporting of kernel execute faults

2017-07-18 Thread Benjamin Herrenschmidt
We currently test for is_exec and DSISR_PROTFAULT but that doesn't make sense as this is the wrong error bit to test for an execute permission failure. In fact, we had code that would return early if we had an exec fault in kernel mode so I think that was just dead code anyway. Finally the locati