Re: [PATCH 11/12] ptp: Added a clock driver for the IXP46x.

2010-06-15 Thread Richard Cochran
On Tue, Jun 15, 2010 at 12:41:56PM -0600, Grant Likely wrote: > Nitpick. We use all lower case names for structures in Linux. Yes, I know, but in this case an exception makes sense. I prefer to use the exact same register mnemonics as in the hardware documentation, whenever possible. That way, a

Re: [PATCH 11/12] ptp: Added a clock driver for the IXP46x.

2010-06-15 Thread Grant Likely
On Tue, Jun 15, 2010 at 10:10 AM, Richard Cochran wrote: > This patch adds a driver for the hardware time stamping unit found on the > IXP465. Only the basic clock operations are implemented. > > Signed-off-by: Richard Cochran Hi Richard, Comments below... > --- >  arch/arm/mach-ixp4xx/include

[PATCH 11/12] ptp: Added a clock driver for the IXP46x.

2010-06-15 Thread Richard Cochran
This patch adds a driver for the hardware time stamping unit found on the IXP465. Only the basic clock operations are implemented. Signed-off-by: Richard Cochran --- arch/arm/mach-ixp4xx/include/mach/ixp46x_ts.h | 67 +++ drivers/net/arm/ixp4xx_eth.c | 194 +++