Re: [PATCH 10/18] Uartlite: improve in-code comments

2007-10-02 Thread Peter Korsgaard
> "Grant" == Grant Likely <[EMAIL PROTECTED]> writes: Grant> From: Grant Likely <[EMAIL PROTECTED]> Grant> Signed-off-by: Grant Likely <[EMAIL PROTECTED]> Fine by me. Acked-by: Peter Korsgaard <[EMAIL PROTECTED]> -- Bye, Peter Korsgaard ___ Lin

Re: [PATCH 10/18] Uartlite: improve in-code comments

2007-09-28 Thread Grant Likely
On 9/28/07, Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Friday 28 September 2007, Grant Likely wrote: > > +/* - > > + * Core UART driver operations > > + */ > > + > > This is a rather unusual style of commenting. IMHO it would be

Re: [PATCH 10/18] Uartlite: improve in-code comments

2007-09-28 Thread Arnd Bergmann
On Friday 28 September 2007, Grant Likely wrote: > +/* - > + * Core UART driver operations > + */ > + This is a rather unusual style of commenting. IMHO it would be better if you left out the - line. Arnd <><

[PATCH 10/18] Uartlite: improve in-code comments

2007-09-28 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- drivers/serial/uartlite.c | 43 --- 1 files changed, 40 insertions(+), 3 deletions(-) diff --git a/drivers/serial/uartlite.c b/drivers/serial/uartlite.c index c00