Re: [PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-06-10 Thread Kumar Gala
On May 23, 2008, at 11:38 AM, Anton Vorontsov wrote: GTM stands for General-purpose Timers Module and able to generate timer{1,2,3,4} interrupts. These timers are used by the drivers that need time precise interrupts (like for USB transactions scheduling for the Freescale USB Host controller as

[PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-23 Thread Anton Vorontsov
GTM stands for General-purpose Timers Module and able to generate timer{1,2,3,4} interrupts. These timers are used by the drivers that need time precise interrupts (like for USB transactions scheduling for the Freescale USB Host controller as found in some QE and CPM chips), or these timers could b

Re: [PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-20 Thread Timur Tabi
Anton Vorontsov wrote: > Btw, this is silent config, selected by the board's Kconfig > (same as QE block, for example). So "depends on" here is just > no-op, since select disregards dependencies. Still want this? FYI, I have plans to modify the Kconfigs so that CONFIG_QUICC_ENGINE is user-selecta

Re: [PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-20 Thread Anton Vorontsov
On Tue, May 20, 2008 at 06:32:34PM +0400, Anton Vorontsov wrote: > On Tue, May 20, 2008 at 09:20:50AM -0500, Kumar Gala wrote: > > This is explained in the .c file with a kernel doc. Basically the > difference is that timer16 could silently crop the precision, while > utimer16 could n

Re: [PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-20 Thread Anton Vorontsov
On Tue, May 20, 2008 at 09:20:50AM -0500, Kumar Gala wrote: > This is explained in the .c file with a kernel doc. Basically the difference is that timer16 could silently crop the precision, while utimer16 could not thus explicitly accepts u16 argument (max. timer interval with us

Re: [PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-20 Thread Grant Likely
On Tue, May 20, 2008 at 7:15 AM, Kumar Gala <[EMAIL PROTECTED]> wrote: >> There (and in the QE GPIO) was an arch_initcall, but based on >> Grant Likely's review it was removed in favour of platform-specific >> machine_initcalls. >> >> See http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg16469

Re: [PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-20 Thread Kumar Gala
This is explained in the .c file with a kernel doc. Basically the difference is that timer16 could silently crop the precision, while utimer16 could not thus explicitly accepts u16 argument (max. timer interval with usec precision fits in u16). Maybe I'm confused what the utility is of cropping

Re: [PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-20 Thread Anton Vorontsov
On Tue, May 20, 2008 at 08:15:15AM -0500, Kumar Gala wrote: [...] + for_each_compatible_node(np, NULL, "fsl,gtm") { + int i; + struct gtm *gtm; + const u32 *clock; + int size; + + gtm = kzalloc(sizeof(*gtm), GFP_KERNEL

Re: [PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-20 Thread Kumar Gala
On May 20, 2008, at 7:41 AM, Anton Vorontsov wrote: On Tue, May 20, 2008 at 01:04:55AM -0500, Kumar Gala wrote: On May 19, 2008, at 12:46 PM, Anton Vorontsov wrote: GTM stands for General-purpose Timers Module and able to generate timer{1,2,3,4} interrupts. These timers are used by the driv

Re: [PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-20 Thread Kumar Gala
+void __init fsl_gtm_init(void) +{ + struct device_node *np; + + for_each_compatible_node(np, NULL, "fsl,gtm") { + int i; + struct gtm *gtm; + const u32 *clock; + int size; + + gtm = kzalloc(sizeof(*gtm), GFP_KERNEL)

Re: [PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-20 Thread Anton Vorontsov
On Tue, May 20, 2008 at 01:04:55AM -0500, Kumar Gala wrote: > > On May 19, 2008, at 12:46 PM, Anton Vorontsov wrote: > >> GTM stands for General-purpose Timers Module and able to generate >> timer{1,2,3,4} interrupts. These timers are used by the drivers that >> need time precise interrupts (like f

Re: [PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-20 Thread Anton Vorontsov
On Tue, May 20, 2008 at 01:04:55AM -0500, Kumar Gala wrote: [...] >> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig >> index 3934e26..e5d3366 100644 >> --- a/arch/powerpc/Kconfig >> +++ b/arch/powerpc/Kconfig >> @@ -538,6 +538,11 @@ config FSL_LBC >> help >>Freescale Localbus

Re: [PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-19 Thread Kumar Gala
On May 19, 2008, at 12:46 PM, Anton Vorontsov wrote: GTM stands for General-purpose Timers Module and able to generate timer{1,2,3,4} interrupts. These timers are used by the drivers that need time precise interrupts (like for USB transactions scheduling for the Freescale USB Host controller as

[PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-19 Thread Anton Vorontsov
GTM stands for General-purpose Timers Module and able to generate timer{1,2,3,4} interrupts. These timers are used by the drivers that need time precise interrupts (like for USB transactions scheduling for the Freescale USB Host controller as found in some QE and CPM chips), or these timers could b