On Tue, Apr 28, 2020 at 10:51:56AM +0800, Jeremy Kerr wrote:
> Hi Al & Christoph,
>
> > Again, this really needs fixing. Preferably - as a separate commit
> > preceding this series, so that it could be
> > backported. simple_read_from_buffer() is a blocking operation.
>
> I'll put together a pa
Hi Al & Christoph,
> Again, this really needs fixing. Preferably - as a separate commit
> preceding this series, so that it could be
> backported. simple_read_from_buffer() is a blocking operation.
I'll put together a patch that fixes this.
Christoph: I'll do it in a way that matches your chan
On Mon, Apr 27, 2020 at 10:06:21PM +0200, Christoph Hellwig wrote:
> @@ -1988,7 +1984,12 @@ static ssize_t spufs_mbox_info_read(struct file *file,
> char __user *buf,
> if (ret)
> return ret;
> spin_lock(&ctx->csa.register_lock);
> - ret = __spufs_mbox_info_read(ctx,
Replace the coredump ->read method with a ->dump method that must call
dump_emit itself. That way we avoid a buffer allocation an messing with
set_fs() to call into code that is intended to deal with user buffers.
For the ->get case we can now use a small on-stack buffer and avoid
memory allocatio
