Re: [PATCH 1/5] KVM: Move wiping of the kvm->vcpus array to common code

2021-11-16 Thread Paolo Bonzini
On 11/6/21 12:17, Marc Zyngier wrote: If you too believe that this is just wrong, I'm happy to drop the locking altogether. If that breaks someone's flow, they'll shout soon enough. Yes, it's not necessary. It was added in 2009 (commit 988a2cae6a3c, "KVM: Use macro to iterate over vcpus.") a

Re: [PATCH 1/5] KVM: Move wiping of the kvm->vcpus array to common code

2021-11-08 Thread Claudio Imbrenda
On Fri, 5 Nov 2021 19:20:57 + Marc Zyngier wrote: > All architectures have similar loops iterating over the vcpus, > freeing one vcpu at a time, and eventually wiping the reference > off the vcpus array. They are also inconsistently taking > the kvm->lock mutex when wiping the references fro

Re: [PATCH 1/5] KVM: Move wiping of the kvm->vcpus array to common code

2021-11-06 Thread Marc Zyngier
On Fri, 05 Nov 2021 20:12:12 +, Sean Christopherson wrote: > > On Fri, Nov 05, 2021, Marc Zyngier wrote: > > All architectures have similar loops iterating over the vcpus, > > freeing one vcpu at a time, and eventually wiping the reference > > off the vcpus array. They are also inconsistently

[PATCH 1/5] KVM: Move wiping of the kvm->vcpus array to common code

2021-11-05 Thread Marc Zyngier
All architectures have similar loops iterating over the vcpus, freeing one vcpu at a time, and eventually wiping the reference off the vcpus array. They are also inconsistently taking the kvm->lock mutex when wiping the references from the array. Make this code common, which will simplify further