Re: [PATCH 1/4] mm: Move ioremap page table mapping function to mm/

Christophe Leroy's on June 19, 2019 11:18 pm: > > > Le 19/06/2019 à 05:43, Nicholas Piggin a écrit : >> Christophe Leroy's on June 11, 2019 3:24 pm: >>> >>> >>> Le 10/06/2019 à 06:38, Nicholas Piggin a écrit : > > [snip] > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h

Re: [PATCH 1/4] mm: Move ioremap page table mapping function to mm/

Le 19/06/2019 à 05:43, Nicholas Piggin a écrit : Christophe Leroy's on June 11, 2019 3:24 pm: Le 10/06/2019 à 06:38, Nicholas Piggin a écrit : [snip] diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h index 51e131245379..812bea5866d6 100644 --- a/include/linux/vmalloc.h +++

Re: [PATCH 1/4] mm: Move ioremap page table mapping function to mm/

Christophe Leroy's on June 11, 2019 3:24 pm: > > > Le 10/06/2019 à 06:38, Nicholas Piggin a écrit : >> ioremap_page_range is a generic function to create a kernel virtual >> mapping, move it to mm/vmalloc.c and rename it vmap_range. >> >> For clarity with this move, also: >> - Rename vunmap_page

Re: [PATCH 1/4] mm: Move ioremap page table mapping function to mm/

Le 10/06/2019 à 06:38, Nicholas Piggin a écrit : ioremap_page_range is a generic function to create a kernel virtual mapping, move it to mm/vmalloc.c and rename it vmap_range. For clarity with this move, also: - Rename vunmap_page_range (vmap_range's inverse) to vunmap_range. - Rename vmap_pa

Re: [PATCH 1/4] mm: Move ioremap page table mapping function to mm/

Anshuman Khandual's on June 10, 2019 3:42 pm: > > > On 06/10/2019 10:08 AM, Nicholas Piggin wrote: >> ioremap_page_range is a generic function to create a kernel virtual >> mapping, move it to mm/vmalloc.c and rename it vmap_range. > > Absolutely. It belongs in mm/vmalloc.c as its a kernel virtu

Re: [PATCH 1/4] mm: Move ioremap page table mapping function to mm/

On 06/10/2019 10:08 AM, Nicholas Piggin wrote: > ioremap_page_range is a generic function to create a kernel virtual > mapping, move it to mm/vmalloc.c and rename it vmap_range. Absolutely. It belongs in mm/vmalloc.c as its a kernel virtual range. But what is the rationale of changing the name

[PATCH 1/4] mm: Move ioremap page table mapping function to mm/

ioremap_page_range is a generic function to create a kernel virtual mapping, move it to mm/vmalloc.c and rename it vmap_range. For clarity with this move, also: - Rename vunmap_page_range (vmap_range's inverse) to vunmap_range. - Rename vmap_page_range (which takes a page array) to vmap_pages. Si