Re: [PATCH 1/4] leds: Support OpenFirmware led bindings

2008-12-11 Thread Trent Piepho
On Wed, 10 Dec 2008, Anton Vorontsov wrote: >> +gpio_direction_output(led_dat->gpio, led_dat->active_low); > > This can fail (yeah, the original code didn't check return value > either). I've added a check. >> +unsigned int flags; > > I think it would be better to use `enum of_gpi

Re: [PATCH 1/4] leds: Support OpenFirmware led bindings

2008-12-10 Thread Anton Vorontsov
Hi Trent, On Wed, Dec 10, 2008 at 07:41:40AM -0800, Trent Piepho wrote: > Add bindings to support LEDs defined as of_platform devices in addition to > the existing bindings for platform devices. > > New options in Kconfig allow the platform binding code and/or the > of_platform code to be turned

[PATCH 1/4] leds: Support OpenFirmware led bindings

2008-12-10 Thread Trent Piepho
Add bindings to support LEDs defined as of_platform devices in addition to the existing bindings for platform devices. New options in Kconfig allow the platform binding code and/or the of_platform code to be turned on. The of_platform code is of course only available on archs that have OF support