Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier

2010-03-05 Thread Anton Vorontsov
On Fri, Mar 05, 2010 at 11:59:18AM -0800, Andrew Morton wrote: [...] > > > /** > > > * gpiochip_add() - register a gpio_chip > > > * @chip: the chip to register, with chip->base initialized > > > @@ -1103,6 +1107,9 @@ fail: > > >pr_err("gpiochip_add: gpios %d..%d (%s) not registered\n", > >

Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier

2010-03-05 Thread Andrew Morton
On Tue, 9 Feb 2010 10:16:44 -0700 Grant Likely wrote: > On Fri, Feb 5, 2010 at 1:32 PM, Anton Vorontsov > wrote: > > Some platforms (e.g. OpenFirmware) want to know when a particular chip > > added or removed, so that the platforms could add their specifics for > > non-platform devices, like I2C

Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier

2010-02-09 Thread Grant Likely
On Fri, Feb 5, 2010 at 1:32 PM, Anton Vorontsov wrote: > Some platforms (e.g. OpenFirmware) want to know when a particular chip > added or removed, so that the platforms could add their specifics for > non-platform devices, like I2C or SPI GPIO chips. > > This patch implements the notifier for chi

[PATCH 1/4] gpiolib: Introduce chip addition/removal notifier

2010-02-05 Thread Anton Vorontsov
Some platforms (e.g. OpenFirmware) want to know when a particular chip added or removed, so that the platforms could add their specifics for non-platform devices, like I2C or SPI GPIO chips. This patch implements the notifier for chip addition and removal events. Signed-off-by: Anton Vorontsov -

Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier

2010-01-26 Thread David Brownell
On Tuesday 26 January 2010, Anton Vorontsov wrote: > > Just > > inline the little two blocking_notifier_call_chain() calls directly, > > making this a *LOT* simpler. > > I'd rather stay with gpio_call_chain() helper, it makes the code > a little bit prettier, IMO. Compare this: The one without th

Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier

2010-01-26 Thread Anton Vorontsov
On Mon, Jan 25, 2010 at 10:34:29PM -0800, David Brownell wrote: > On Monday 25 January 2010, Anton Vorontsov wrote: > > > > +config GPIOLIB_NOTIFIER > > +   bool > > +   help > > +     This symbol is selected by subsystems that need to handle GPIO > > +     chips addition and remov

Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier

2010-01-25 Thread David Brownell
On Monday 25 January 2010, Anton Vorontsov wrote: > > +config GPIOLIB_NOTIFIER > +   bool > +   help > +     This symbol is selected by subsystems that need to handle GPIO > +     chips addition and removal. E.g., this is used for the > +     OpenFirmware bindings. > + I'm no

[PATCH 1/4] gpiolib: Introduce chip addition/removal notifier

2010-01-25 Thread Anton Vorontsov
Some platforms (e.g. OpenFirmware) want to know when a particular chip added or removed, so that the platforms could add their specifics for non-platform devices, like I2C or SPI GPIO chips. This patch implements the notifier for chip addition and removal events. Signed-off-by: Anton Vorontsov -