Re: [PATCH 1/4] fs: always build llseek.

2019-08-29 Thread Michal Suchánek
On Wed, 28 Aug 2019 23:22:00 -0700 Christoph Hellwig wrote: > On Wed, Aug 28, 2019 at 06:15:40PM +0200, Michal Suchánek wrote: > > On Wed, 28 Aug 2019 08:15:52 -0700 > > Christoph Hellwig wrote: > > > > > On Tue, Aug 27, 2019 at 10:21:06PM +0200, Michal Suchanek wrote: > > > > 64bit !COMPAT

Re: [PATCH 1/4] fs: always build llseek.

2019-08-28 Thread Christoph Hellwig
On Wed, Aug 28, 2019 at 06:15:40PM +0200, Michal Suchánek wrote: > On Wed, 28 Aug 2019 08:15:52 -0700 > Christoph Hellwig wrote: > > > On Tue, Aug 27, 2019 at 10:21:06PM +0200, Michal Suchanek wrote: > > > 64bit !COMPAT does not build because the llseek syscall is in the tables. > > > > > > >

Re: [PATCH 1/4] fs: always build llseek.

2019-08-28 Thread Eric W. Biederman
Michal Suchanek writes: > 64bit !COMPAT does not build because the llseek syscall is in the > tables. Do I read this right you have a 128 bit offset to llseek on ppc64? Looking at the signature it does not appear to make sense to build this function on any 64bit platform. Perhaps the proper fi

Re: [PATCH 1/4] fs: always build llseek.

2019-08-28 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: > Michal Suchanek writes: > >> 64bit !COMPAT does not build because the llseek syscall is in the >> tables. > > Do I read this right you have a 128 bit offset to llseek on ppc64? > > Looking at the signature it does not appear to make sense to bui

Re: [PATCH 1/4] fs: always build llseek.

2019-08-28 Thread Michal Suchánek
On Wed, 28 Aug 2019 08:15:52 -0700 Christoph Hellwig wrote: > On Tue, Aug 27, 2019 at 10:21:06PM +0200, Michal Suchanek wrote: > > 64bit !COMPAT does not build because the llseek syscall is in the tables. > > Well, this will bloat thinkgs like 64-bit RISC-V for no good reason. > Please introdu

Re: [PATCH 1/4] fs: always build llseek.

2019-08-28 Thread Christoph Hellwig
On Tue, Aug 27, 2019 at 10:21:06PM +0200, Michal Suchanek wrote: > 64bit !COMPAT does not build because the llseek syscall is in the tables. Well, this will bloat thinkgs like 64-bit RISC-V for no good reason. Please introduce a WANT_LSEEK like symbol that ppc64 can select instead.

[PATCH 1/4] fs: always build llseek.

2019-08-27 Thread Michal Suchanek
64bit !COMPAT does not build because the llseek syscall is in the tables. Signed-off-by: Michal Suchanek --- fs/read_write.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index 5bbf587f5bc1..9db56931eb26 100644 --- a/fs/read_write.c +++ b/fs/read_write.c