Re: [PATCH 1/4] PowerPC 440EPx: Sequoia bootwrapper

2007-08-29 Thread David Gibson
On Wed, Aug 29, 2007 at 05:38:30PM +0400, Valentine Barshak wrote: > Bootwrapper code for AMCC PPC440EPx Sequoia. > > Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> Acked-by: David Gibson <[EMAIL PROTECTED]> -- David Gibson| I'll have my music baroque, and my code davi

[PATCH 1/4] PowerPC 440EPx: Sequoia bootwrapper

2007-08-29 Thread Valentine Barshak
Bootwrapper code for AMCC PPC440EPx Sequoia. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/boot/4xx.c| 108 + arch/powerpc/boot/4xx.h|1 arch/powerpc/boot/Makefile |4 + arch/powerpc/boot/cuboot-

Re: [PATCH 1/4] PowerPC 440EPx: Sequoia bootwrapper

2007-08-29 Thread Stefan Roese
On Wednesday 29 August 2007, Valentine Barshak wrote: > >> +#define DDR_GET_VAL(val, mask, shift) (((val) >> (shift)) & (mask)) > > > > Hm. Having these as just DDR_... seems like it would lead to confusion > > if there are other DDR controllers that get added later. But I'm not > > too picky

Re: [PATCH 1/4] PowerPC 440EPx: Sequoia bootwrapper

2007-08-29 Thread Josh Boyer
On Wed, 29 Aug 2007 14:28:23 +0200 Stefan Roese <[EMAIL PROTECTED]> wrote: > On Wednesday 29 August 2007, Valentine Barshak wrote: > > >> +#define DDR_GET_VAL(val, mask, shift) (((val) >> (shift)) & (mask)) > > > > > > Hm. Having these as just DDR_... seems like it would lead to confusion > > >

Re: [PATCH 1/4] PowerPC 440EPx: Sequoia bootwrapper

2007-08-29 Thread Valentine Barshak
David Gibson wrote: > On Tue, Aug 28, 2007 at 08:56:10PM +0400, Valentine Barshak wrote: >> Bootwrapper code for AMCC PPC440EPx Sequoia. >> >> Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> > [snip] >> +static void sequoia_fixups(void) >> +{ >> +unsigned long sysclk = ; >> + >> +

Re: [PATCH 1/4] PowerPC 440EPx: Sequoia bootwrapper

2007-08-29 Thread Valentine Barshak
Josh Boyer wrote: > On Tue, 28 Aug 2007 20:56:10 +0400 > Valentine Barshak <[EMAIL PROTECTED]> wrote: > >> +/* 4xx DDR1/2 Denali memory controller support */ >> +/* DDR0 registers */ >> +#define DDR0_02 2 >> +#define DDR0_08 8 >> +#define DDR0_10

Re: [PATCH 1/4] PowerPC 440EPx: Sequoia bootwrapper

2007-08-28 Thread David Gibson
On Tue, Aug 28, 2007 at 08:56:10PM +0400, Valentine Barshak wrote: > Bootwrapper code for AMCC PPC440EPx Sequoia. > > Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> [snip] > +static void sequoia_fixups(void) > +{ > + unsigned long sysclk = ; > + > + ibm440ep_fixup_clocks(sysc

Re: [PATCH 1/4] PowerPC 440EPx: Sequoia bootwrapper

2007-08-28 Thread Josh Boyer
On Tue, 28 Aug 2007 20:56:10 +0400 Valentine Barshak <[EMAIL PROTECTED]> wrote: > +/* 4xx DDR1/2 Denali memory controller support */ > +/* DDR0 registers */ > +#define DDR0_02 2 > +#define DDR0_08 8 > +#define DDR0_10 10 > +#define DDR

[PATCH 1/4] PowerPC 440EPx: Sequoia bootwrapper

2007-08-28 Thread Valentine Barshak
Bootwrapper code for AMCC PPC440EPx Sequoia. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/boot/4xx.c| 108 + arch/powerpc/boot/4xx.h|1 arch/powerpc/boot/Makefile |4 + arch/powerpc/boot/cuboot-