Re: [PATCH 1/4] [POWERPC] Implement GPIO API embryo

2007-12-23 Thread Segher Boessenkool
> I think part of what's happening here is due to the patch's history. That doesn't make it right though ;-) > Obviously a > driver for a particular gpio controller would generally need to assert > that the controller's #gpio-cells has the correct value for this > controller type, after which cod

Re: [PATCH 1/4] [POWERPC] Implement GPIO API embryo

2007-12-22 Thread David Gibson
On Sun, Dec 23, 2007 at 03:49:30AM +0100, Segher Boessenkool wrote: > > +int __of_parse_gpio_bank_pin(struct device_node *np, int index, > > +int bank_width, int max_bank) > > +{ > > + int bank; > > + int pin; > > + const u32 *gpios; > > + > > + /* > > +* We can

Re: [PATCH 1/4] [POWERPC] Implement GPIO API embryo

2007-12-22 Thread Segher Boessenkool
> +int __of_parse_gpio_bank_pin(struct device_node *np, int index, > + int bank_width, int max_bank) > +{ > + int bank; > + int pin; > + const u32 *gpios; > + > + /* > + * We can get there only if of_get_gpio() succeeded, thus > + * no need checkin

[PATCH 1/4] [POWERPC] Implement GPIO API embryo

2007-12-21 Thread Anton Vorontsov
This patch implements GPIO API as described in Documentation/gpio.txt. Two calls unimplemented though: irq_to_gpio and gpio_to_irq. This patch also provides OF helpers. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- arch/powerpc/Kconfig |3 ++ arch/powerpc/kernel/prom_par