Re: [PATCH 1/3] uprobes: add trap variant helper

2013-03-22 Thread Ananth N Mavinakayanahalli
On Fri, Mar 22, 2013 at 03:54:06PM +0100, Oleg Nesterov wrote: > On 03/22, Ananth N Mavinakayanahalli wrote: > > > > +/** > > + * is_trap_insn - check if instruction is breakpoint instruction. > > + * @insn: instruction to be checked. > > + * Default implementation of is_trap_insn > > + * Returns t

Re: [PATCH 1/3] uprobes: add trap variant helper

2013-03-22 Thread Oleg Nesterov
On 03/22, Ananth N Mavinakayanahalli wrote: > > +/** > + * is_trap_insn - check if instruction is breakpoint instruction. > + * @insn: instruction to be checked. > + * Default implementation of is_trap_insn > + * Returns true if @insn is a breakpoint instruction. > + * > + * This function is needed

[PATCH 1/3] uprobes: add trap variant helper

2013-03-22 Thread Ananth N Mavinakayanahalli
From: Ananth N Mavinakayanahalli Some architectures like powerpc have multiple variants of the trap instruction. Introduce an additional helper is_trap_insn() for run-time handling of non-uprobe traps on such architectures. While there, change is_swbp_at_addr() to is_trap_at_addr() for reading c