Re: [PATCH 1/3] powerpc: Relocate prom_init.c on 64bit

2012-12-04 Thread Benjamin Herrenschmidt
On Wed, 2012-12-05 at 11:07 +1100, Anton Blanchard wrote: > Hi Ben, > > > My only potential objection was that it might have been cleaner to > > actually build prom_init.c as a separate binary alltogether and piggy > > back it... > > Yeah, I went through a number of options before settling on thi

Re: [PATCH 1/3] powerpc: Relocate prom_init.c on 64bit

2012-12-04 Thread Anton Blanchard
Hi Ben, > My only potential objection was that it might have been cleaner to > actually build prom_init.c as a separate binary alltogether and piggy > back it... Yeah, I went through a number of options before settling on this one. Move prom_init.c into arch/powerpc/boot Pros: - 32 bit enviro

Re: [PATCH 1/3] powerpc: Relocate prom_init.c on 64bit

2012-11-26 Thread Benjamin Herrenschmidt
On Tue, 2012-11-27 at 14:39 +1100, Anton Blanchard wrote: > The ppc64 kernel can get loaded at any address which means > our very early init code in prom_init.c must be relocatable. We do > this with a pretty nasty RELOC() macro that we wrap accesses of > variables with. It is very fragile and some

[PATCH 1/3] powerpc: Relocate prom_init.c on 64bit

2012-11-26 Thread Anton Blanchard
The ppc64 kernel can get loaded at any address which means our very early init code in prom_init.c must be relocatable. We do this with a pretty nasty RELOC() macro that we wrap accesses of variables with. It is very fragile and sometimes we forget to add a RELOC() to an uncommon path or sometimes