Re: [PATCH 1/3] powerpc: Don't use local named register variable in current_thread_info

2015-01-07 Thread Alan Modra
On Wed, Jan 07, 2015 at 04:12:47PM +1100, Anton Blanchard wrote: > Hi Alan, > > > Right. This is really an rs6000 backend bug. We describe one of the > > indirect calls that go wrong here as > > > > (call_insn 108 107 109 13 (parallel [ > > (set (reg:DI 3 3) > > (cal

Re: [PATCH 1/3] powerpc: Don't use local named register variable in current_thread_info

2015-01-07 Thread Scott Wood
On Wed, 2015-01-07 at 16:12 +1100, Anton Blanchard wrote: > Thanks for looking into this. Does that mean we were just getting lucky > with the previous version: > > static inline struct thread_info *current_thread_info(void) > { > register unsigned long sp asm("r1"); > > return (s

Re: [PATCH 1/3] powerpc: Don't use local named register variable in current_thread_info

2015-01-06 Thread Anton Blanchard
Hi Alan, > Right. This is really an rs6000 backend bug. We describe one of the > indirect calls that go wrong here as > > (call_insn 108 107 109 13 (parallel [ > (set (reg:DI 3 3) > (call (mem:SI (reg:DI 288) [0 *_67 S4 A8]) > (const_int 64 [0x40]

Re: [PATCH 1/3] powerpc: Don't use local named register variable in current_thread_info

2014-12-31 Thread Alan Modra
On Thu, Dec 18, 2014 at 05:25:46PM +1100, Anton Blanchard wrote: > On Thu, 18 Dec 2014 16:11:54 +1100 > Michael Ellerman wrote: > > > On Wed, 2014-12-17 at 02:16 +0100, Alexander Graf wrote: > > > On 31.10.14 04:47, Anton Blanchard wrote: > > > > LLVM doesn't support local named register variable

Re: [PATCH 1/3] powerpc: Don't use local named register variable in current_thread_info

2014-12-21 Thread Michael Ellerman
On Wed, 2014-12-17 at 10:27 +0100, Alexander Graf wrote: > > On 17.12.14 04:44, Anton Blanchard wrote: > > Hi Alex, > > > >> Git bisect managed to point me to this commit as the offender for > >> OOPSes on e5500 and e6500 (and maybe the G4 as well, not sure). > >> > >> Doing a git revert of this

Re: [PATCH 1/3] powerpc: Don't use local named register variable in current_thread_info

2014-12-18 Thread Alexander Graf
On 18.12.14 07:25, Anton Blanchard wrote: > On Thu, 18 Dec 2014 16:11:54 +1100 > Michael Ellerman wrote: > >> On Wed, 2014-12-17 at 02:16 +0100, Alexander Graf wrote: >>> On 31.10.14 04:47, Anton Blanchard wrote: LLVM doesn't support local named register variables and is unlikely to.

Re: [PATCH 1/3] powerpc: Don't use local named register variable in current_thread_info

2014-12-18 Thread Alexander Graf
On 18.12.14 06:11, Michael Ellerman wrote: > On Wed, 2014-12-17 at 02:16 +0100, Alexander Graf wrote: >> On 31.10.14 04:47, Anton Blanchard wrote: >>> LLVM doesn't support local named register variables and is unlikely >>> to. current_thread_info is using one, fix it by moving it out and >>> call

Re: [PATCH 1/3] powerpc: Don't use local named register variable in current_thread_info

2014-12-17 Thread Anton Blanchard
On Thu, 18 Dec 2014 16:11:54 +1100 Michael Ellerman wrote: > On Wed, 2014-12-17 at 02:16 +0100, Alexander Graf wrote: > > On 31.10.14 04:47, Anton Blanchard wrote: > > > LLVM doesn't support local named register variables and is > > > unlikely to. current_thread_info is using one, fix it by movin

Re: [PATCH 1/3] powerpc: Don't use local named register variable in current_thread_info

2014-12-17 Thread Michael Ellerman
On Wed, 2014-12-17 at 02:16 +0100, Alexander Graf wrote: > On 31.10.14 04:47, Anton Blanchard wrote: > > LLVM doesn't support local named register variables and is unlikely > > to. current_thread_info is using one, fix it by moving it out and > > calling it __current_r1(). > > > > I gave it a bit

Re: [PATCH 1/3] powerpc: Don't use local named register variable in current_thread_info

2014-12-17 Thread Alexander Graf
On 17.12.14 04:44, Anton Blanchard wrote: > Hi Alex, > >> Git bisect managed to point me to this commit as the offender for >> OOPSes on e5500 and e6500 (and maybe the G4 as well, not sure). >> >> Doing a git revert of this commit on top of linus/master makes things >> work fine for me again. >

Re: [PATCH 1/3] powerpc: Don't use local named register variable in current_thread_info

2014-12-16 Thread Anton Blanchard
Hi Alex, > Git bisect managed to point me to this commit as the offender for > OOPSes on e5500 and e6500 (and maybe the G4 as well, not sure). > > Doing a git revert of this commit on top of linus/master makes things > work fine for me again. Ouch, sorry for that, I'll work to reproduce. What gc

Re: [PATCH 1/3] powerpc: Don't use local named register variable in current_thread_info

2014-12-16 Thread Alexander Graf
On 31.10.14 04:47, Anton Blanchard wrote: > LLVM doesn't support local named register variables and is unlikely > to. current_thread_info is using one, fix it by moving it out and > calling it __current_r1(). > > I gave it a bit of an obscure name because we don't want anyone else > using it - the

[PATCH 1/3] powerpc: Don't use local named register variable in current_thread_info

2014-10-30 Thread Anton Blanchard
LLVM doesn't support local named register variables and is unlikely to. current_thread_info is using one, fix it by moving it out and calling it __current_r1(). I gave it a bit of an obscure name because we don't want anyone else using it - they should use current_stack_pointer(). This specific ca