Re: [PATCH 1/3] powerpc: Add mmc-spi-slot bindings

2008-10-30 Thread David Gibson
On Fri, Oct 31, 2008 at 02:02:53AM +0300, Anton Vorontsov wrote: > On Thu, Oct 30, 2008 at 02:37:31PM -0600, Grant Likely wrote: > [...] > > > +- gpios : (optional) may specify GPIOs in this order: Card-Detect GPIO, > > > + Write-Protect GPIO. > > > > I wonder if we're following the example of ir

Re: [PATCH 1/3] powerpc: Add mmc-spi-slot bindings

2008-10-30 Thread Anton Vorontsov
On Fri, Oct 31, 2008 at 02:02:53AM +0300, Anton Vorontsov wrote: [...] > It's pretty trivial to implement (of_get_named_gpio() -- could be just > factored out of of_get_gpio()). > > Though, > > 1. The idea is quite extreme. It needs discussion, and furthermore, >we need to define when do we u

Re: [PATCH 1/3] powerpc: Add mmc-spi-slot bindings

2008-10-30 Thread Anton Vorontsov
On Thu, Oct 30, 2008 at 02:37:31PM -0600, Grant Likely wrote: [...] > > +- gpios : (optional) may specify GPIOs in this order: Card-Detect GPIO, > > + Write-Protect GPIO. > > I wonder if we're following the example of irq mappings too closely > for the gpios property. I like the layout of the pr

Re: [PATCH 1/3] powerpc: Add mmc-spi-slot bindings

2008-10-30 Thread Grant Likely
On Thu, Oct 30, 2008 at 1:56 PM, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > The bindings describes a case where MMC/SD/SDIO slot directly connected > to a SPI bus. Such setups are widely used on embedded PowerPC boards. > > The patch also adds the mmc-spi-slot entry to the OpenFirmware modalias >

[PATCH 1/3] powerpc: Add mmc-spi-slot bindings

2008-10-30 Thread Anton Vorontsov
The bindings describes a case where MMC/SD/SDIO slot directly connected to a SPI bus. Such setups are widely used on embedded PowerPC boards. The patch also adds the mmc-spi-slot entry to the OpenFirmware modalias table. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- .../powerpc/dts-bind