Re: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c

2011-11-17 Thread Artem Bityutskiy
On Tue, 2011-11-15 at 17:29 +0800, b35...@freescale.com wrote: > From: Liu Shuo > > fix whitespaces,tabs coding style issue and use #include instead > of > in drivers/mtd/nand/fsl_elbc.c. > > Signed-off-by: Liu Shuo > Signed-off-by: Li Yang Hi, It is really matter of taste whether to use o

RE: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c

2011-11-15 Thread David Woodhouse
On Tue, 2011-11-15 at 14:42 +, Jenkins, Clive wrote: > This may be your (not so humble :-) opinion, and I happen to agree that > a tab setting of 8 is best, usually. However, as Linus says in his > coding style document "Coding style is very personal, and I won't _force_ > my views on anybody".

RE: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c

2011-11-15 Thread David Laight
> On Tue, 2011-11-15 at 11:26 +, Jenkins, Clive wrote: > > > fix whitespaces,tabs coding style issue and ... > > > > In my opinion this code was already correct, and would display correctly > > at any TAB setting. This patch changes it so that it displays > > incorrectly at all TAB settings

RE: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c

2011-11-15 Thread Jenkins, Clive
> > > fix whitespaces,tabs coding style issue and ... > > > > In my opinion this code was already correct, and would display correctly > > at any TAB setting. This patch changes it so that it displays > > incorrectly at all TAB settings other than 8. > > Any tab setting other than 8 is incorrect a

RE: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c

2011-11-15 Thread David Woodhouse
On Tue, 2011-11-15 at 11:26 +, Jenkins, Clive wrote: > > fix whitespaces,tabs coding style issue and ... > > In my opinion this code was already correct, and would display correctly > at any TAB setting. This patch changes it so that it displays > incorrectly at all TAB settings other than 8.

RE: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c

2011-11-15 Thread Jenkins, Clive
> fix whitespaces,tabs coding style issue and ... In my opinion this code was already correct, and would display correctly at any TAB setting. This patch changes it so that it displays incorrectly at all TAB settings other than 8. Example: Correct: function(arg1, <9spaces>arg2 Incorrect: functi

[PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c

2011-11-15 Thread b35362
From: Liu Shuo fix whitespaces,tabs coding style issue and use #include instead of in drivers/mtd/nand/fsl_elbc.c. Signed-off-by: Liu Shuo Signed-off-by: Li Yang --- drivers/mtd/nand/fsl_elbc_nand.c | 194 +++--- 1 files changed, 97 insertions(+), 97 deleti