Re: [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code

2008-03-01 Thread Benjamin Herrenschmidt
On Sat, 2008-03-01 at 14:43 -0500, Jarod Wilson wrote: > Stefan Richter wrote: > > Copied from ohci1394.c. This code is necessary to prevent machine check > > exceptions when reloading or resuming the driver. > > > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > > I was able to reproduce

Re: [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code

2008-03-01 Thread Jarod Wilson
Stefan Richter wrote: > Copied from ohci1394.c. This code is necessary to prevent machine check > exceptions when reloading or resuming the driver. > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> I was able to reproduce the system exception on resume with a 3rd-gen Titanium PowerBook G4 6

Re: [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code

2008-03-01 Thread Stefan Richter
Benjamin Herrenschmidt wrote: >> +#ifdef CONFIG_PPC_PMAC >> +/* Necessary on some machines if fw-ohci was loaded/ unloaded before */ >> +if (machine_is(powermac)) { >> +struct device_node *ofn = pci_device_to_OF_node(dev); >> + >> +if (ofn) { >> +

Re: [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code

2008-02-29 Thread Benjamin Herrenschmidt
> +#ifdef CONFIG_PPC_PMAC > + /* Necessary on some machines if fw-ohci was loaded/ unloaded before */ > + if (machine_is(powermac)) { > + struct device_node *ofn = pci_device_to_OF_node(dev); > + > + if (ofn) { > + pmac_call_feature(PMAC_FTR_1394

Re: [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code

2008-02-29 Thread Stefan Richter
I wrote: > + struct device_node* ofn = pci_device_to_OF_node(dev); -ECOPYANDWASTE: struct device_node *ofn -- Stefan Richter -=-==--- --== = http://arcgraph.de/sr/ ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlab

[PATCH 1/3] firewire: fw-ohci: PPC PMac platform code

2008-02-29 Thread Stefan Richter
Copied from ohci1394.c. This code is necessary to prevent machine check exceptions when reloading or resuming the driver. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-ohci.c | 50 + 1 file changed, 50 insertions(+) Index