Re: [PATCH 1/3] add default device trees for MPC837x MDS board

2008-01-17 Thread Kumar Gala
On Jan 7, 2008, at 6:03 AM, Li Yang wrote: > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > --- > address comments and use new dts spec. > > arch/powerpc/boot/dts/mpc8377_mds.dts | 277 > +++ > arch/powerpc/boot/dts/mpc8378_mds.dts | 263 > ++

Re: [PATCH 1/3] add default device trees for MPC837x MDS board

2008-01-09 Thread Grant Likely
On 1/9/08, David Gibson <[EMAIL PROTECTED]> wrote: > On Tue, Jan 08, 2008 at 08:58:17AM -0700, Grant Likely wrote: > > > + compatible = "mpc83xx_wdt"; > > > > "fsl,mpc8377_wdt", "fsl,mpc83xx_wdt" as per generic names recommended > > practice. > > Uh.. that's reasonable advice

Re: [PATCH 1/3] add default device trees for MPC837x MDS board

2008-01-09 Thread David Gibson
On Tue, Jan 08, 2008 at 08:58:17AM -0700, Grant Likely wrote: > Hi Leo, > > comments below. I've made my comments on the first file, but they > apply to the other two also. > > Cheers, > g. [snip] > > + ranges = <0 e000 0010>; > > + reg = ; > > +

RE: [PATCH 1/3] add default device trees for MPC837x MDS board

2008-01-09 Thread Li Yang
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On > Behalf Of Grant Likely > Sent: Wednesday, January 09, 2008 1:54 AM > To: Wood Scott > Cc: Li Yang; linuxppc-dev@ozlabs.org; [EMAIL PROTECTED] > Subject: Re: [PATCH 1/3] add default dev

Re: [PATCH 1/3] add default device trees for MPC837x MDS board

2008-01-08 Thread Grant Likely
On 1/8/08, Scott Wood <[EMAIL PROTECTED]> wrote: > On Tue, Jan 08, 2008 at 08:58:17AM -0700, Grant Likely wrote: > > On 1/7/08, Li Yang <[EMAIL PROTECTED]> wrote: > > > + phy_type = "utmi_wide"; > > > > fsl,phy_type please. > > Again, code will break. Can we stop ambushing pe

Re: [PATCH 1/3] add default device trees for MPC837x MDS board

2008-01-08 Thread Scott Wood
On Tue, Jan 08, 2008 at 08:58:17AM -0700, Grant Likely wrote: > On 1/7/08, Li Yang <[EMAIL PROTECTED]> wrote: > > + [EMAIL PROTECTED] { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + device_type = "soc"; > > I recommend dropping device_ty

Re: [PATCH 1/3] add default device trees for MPC837x MDS board

2008-01-08 Thread Grant Likely
Hi Leo, comments below. I've made my comments on the first file, but they apply to the other two also. Cheers, g. On 1/7/08, Li Yang <[EMAIL PROTECTED]> wrote: > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > --- > address comments and use new dts spec. > > arch/powerpc/boot/dts/mpc8377_mds.dts

Re: [PATCH 1/3] add default device trees for MPC837x MDS board

2008-01-08 Thread Kumar Gala
>>> >> >> Could I convince you to convert these to dts-v1 format? > > Ok, I can do it. The DTS spec changes too much lately. :( Thanks. I'll merge the two patches into one when I commit. Its open source development ;) - k ___ Linuxppc-dev mailing

RE: [PATCH 1/3] add default device trees for MPC837x MDS board

2008-01-07 Thread Li Yang
> -Original Message- > From: Kumar Gala [mailto:[EMAIL PROTECTED] > Sent: Tuesday, January 08, 2008 3:37 PM > To: Li Yang > Cc: linuxppc-dev@ozlabs.org; [EMAIL PROTECTED] > Subject: Re: [PATCH 1/3] add default device trees for MPC837x > MDS board > > >

Re: [PATCH 1/3] add default device trees for MPC837x MDS board

2008-01-07 Thread Kumar Gala
On Jan 7, 2008, at 6:03 AM, Li Yang wrote: > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > --- > address comments and use new dts spec. > > arch/powerpc/boot/dts/mpc8377_mds.dts | 277 > +++ > arch/powerpc/boot/dts/mpc8378_mds.dts | 263 > ++

[PATCH 1/3] add default device trees for MPC837x MDS board

2008-01-07 Thread Li Yang
Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- address comments and use new dts spec. arch/powerpc/boot/dts/mpc8377_mds.dts | 277 +++ arch/powerpc/boot/dts/mpc8378_mds.dts | 263 + arch/powerpc/boot/dts/mpc8379_mds.dts | 291