Re: [PATCH 1/3] Raise the upper limit of NR_CPUS.

2008-04-22 Thread Segher Boessenkool
+ unsigned long kernel_toc = (unsigned long)(&__toc_start) + 0x8000UL; This line could do with a comment saying what it is doing ... It does need a comment I agree, but I don't think I can do it justice :) ... I just used what was already there. Here, have one: "The TOC register (GPR2) po

Re: [PATCH 1/3] Raise the upper limit of NR_CPUS.

2008-04-21 Thread Tony Breeds
On Tue, Apr 22, 2008 at 01:50:05PM +1000, Stephen Rothwell wrote: > Hi Tony, > > On Tue, 22 Apr 2008 13:30:06 +1000 (EST) Tony Breeds <[EMAIL PROTECTED]> > wrote: > > > > +void __init initialise_pacas(void) > > +{ > > + int cpu; > > + unsigned long kernel_toc = (unsigned long)(&__toc_start) +

Re: [PATCH 1/3] Raise the upper limit of NR_CPUS.

2008-04-21 Thread Stephen Rothwell
Hi Tony, On Tue, 22 Apr 2008 13:30:06 +1000 (EST) Tony Breeds <[EMAIL PROTECTED]> wrote: > > +void __init initialise_pacas(void) > +{ > + int cpu; > + unsigned long kernel_toc = (unsigned long)(&__toc_start) + 0x8000UL; This line could do with a comment saying what it is doing ... > +++

[PATCH 1/3] Raise the upper limit of NR_CPUS.

2008-04-21 Thread Tony Breeds
As the pacas are statically initialised increasing NR_CPUS beyond 128, means that any additional pacas will be empty ... which is bad. This patch adds the required functionality to fill in any excess pacas at runtime. Signed-off-by: Tony Breeds <[EMAIL PROTECTED]> --- arch/powerpc/kernel/paca.c