Re: [PATCH 1/3] 82xx: some 82xx platform hook functions can be shared by different boards

On Tue, Jul 17, 2007 at 02:59:46AM +0200, Arnd Bergmann wrote: > This is a step in the wrong direction. CPUINFO_{VENDOR,MACHINE} > comes from a platform specific header file, so you can not > use these definitions in platform independent code without > breaking multiplatform kernels. My patchset j

Re: [PATCH 1/3] 82xx: some 82xx platform hook functions can be shared by different boards

On Tue, 2007-07-17 at 02:59 +0200, Arnd Bergmann wrote: > On Monday 16 July 2007, Mark Zhan wrote: > > > @@ -96,7 +94,7 @@ > > pvid = mfspr(SPRN_PVR); > > svid = mfspr(SPRN_SVR); > > > > - seq_printf(m, "Vendor\t\t: Freescale Semiconductor\n"); > > + seq_printf(m, "Vendor\t\t: %s\n",

Re: [PATCH 1/3] 82xx: some 82xx platform hook functions can be shared by different boards

On Monday 16 July 2007, Mark Zhan wrote: > @@ -96,7 +94,7 @@ > pvid = mfspr(SPRN_PVR); > svid = mfspr(SPRN_SVR); > > - seq_printf(m, "Vendor\t\t: Freescale Semiconductor\n"); > + seq_printf(m, "Vendor\t\t: %s\n", CPUINFO_VENDOR); > seq_printf(m, "Machine\t\t: %s\n", CPUI

[PATCH 1/3] 82xx: some 82xx platform hook functions can be shared by different boards

Some mpc82xx platform hooks in mpc82xx_ads.c are actually not specific to ads board, they could be shared by different 82xx boards. Signed-off-by: Mark Zhan <[EMAIL PROTECTED]> --- arch/powerpc/platforms/82xx/mpc82xx.c | 30 +++ arch/powerpc/platforms/82xx/mpc82xx_ad