Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-22 Thread Andrew Lunn
> The reason I mentioned maybe I should put the backplane property in > fsl's binding is because the backplane implementation is really > vendor specific, it's heavily relay how hardware implements the > feature, maybe another vendor's hardware only needs a boolean > property for driver to tell it

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-22 Thread Shaohui Xie
lli; shh@gmail.com; devicet...@vger.kernel.org; net...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; da...@davemloft.net; Shaohui Xie Subject: Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR >> Looking at fsl_backplane_config_aneg() you expect phydev->speed to be &g

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-22 Thread Shaohui Xie
>> Looking at fsl_backplane_config_aneg() you expect phydev->speed to be >> set, and from the speed you then kick of either KR autoneg or KX >> autoneg. Could you also start the training at this point? Use the >> speed to indicate if training is needed? > > [S.H]The training cannot be started at

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-22 Thread Sebastian Hesselbarth
@lists.ozlabs.org; da...@davemloft.net; Shaohui Xie Subject: Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR On Tue, Jan 19, 2016 at 05:00:35AM +, Shaohui Xie wrote: -Original Message- From: Andrew Lunn [mailto:and...@lunn.ch] Sent: Monday, January 18, 2016 11:15 PM To: Shaohui

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-22 Thread Shaohui Xie
Subject: Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR On Tue, Jan 19, 2016 at 05:00:35AM +, Shaohui Xie wrote: > > -Original Message- > > From: Andrew Lunn [mailto:and...@lunn.ch] > > Sent: Monday, January 18, 2016 11:15 PM > > To: Shaoh

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-21 Thread Andrew Lunn
shh@gmail.com; > > devicet...@vger.kernel.org; net...@vger.kernel.org; linuxppc- > > d...@lists.ozlabs.org; da...@davemloft.net; Shaohui Xie > > Subject: Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR > > > > > [S.H] the fsl backplane, e.g. 10GBASE-KR, n

RE: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-18 Thread Shaohui Xie
@lists.ozlabs.org; da...@davemloft.net; Shaohui Xie > Subject: Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR > > > [S.H] the fsl backplane, e.g. 10GBASE-KR, needs software to handle > > link training, It's to train link partner, and trained by link partner

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-18 Thread Andrew Lunn
> [S.H] the fsl backplane, e.g. 10GBASE-KR, needs software to handle link > training, > It's to train link partner, and trained by link partner parallel. > > But if media type is not copper, e.g. optical module, we won't need this. So what we actually need to know is copper vs fibre? Andrew

RE: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-18 Thread Shaohui Xie
; linuxppc- > d...@lists.ozlabs.org; da...@davemloft.net; Shaohui Xie > Subject: Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR > > On 18.01.2016 08:23, Shaohui Xie wrote: > >>> If you look at the list of possible values for "phy-mode" you'd see > >

RE: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-18 Thread Shaohui Xie
> > If you look at the list of possible values for "phy-mode" you'd see > > that none of it describes a PHY-to-PHY connection but all are for > > MAC-to-PHY connections. Also, names above suggest it already: MII is > > short for media _independent_ interface. > > > > I copy Andrew's concerns and th

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-18 Thread Sebastian Hesselbarth
On 18.01.2016 08:23, Shaohui Xie wrote: If you look at the list of possible values for "phy-mode" you'd see that none of it describes a PHY-to-PHY connection but all are for MAC-to-PHY connections. Also, names above suggest it already: MII is short for media _independent_ interface. I copy Andre

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-15 Thread Florian Fainelli
>>> Cc: devicet...@vger.kernel.org; net...@vger.kernel.org; linuxppc- >>> d...@lists.ozlabs.org; f.faine...@gmail.com; da...@davemloft.net; Shaohui >>> Xie >>> Subject: Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR >>> >>> On Thu, Jan

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-15 Thread Sebastian Hesselbarth
sts.ozlabs.org; f.faine...@gmail.com; da...@davemloft.net; Shaohui Xie >> Subject: Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR >> >> On Thu, Jan 14, 2016 at 04:23:59PM +0800, shh@gmail.com wrote: >>> From: Shaohui Xie >>> &

RE: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-14 Thread Shaohui Xie
ohui Xie > Subject: Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR > > On Thu, Jan 14, 2016 at 04:23:59PM +0800, shh@gmail.com wrote: > > From: Shaohui Xie > > > > This commit adds necessary definitions for the PHY layer to recognize > > bac

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-14 Thread Andrew Lunn
On Thu, Jan 14, 2016 at 04:23:59PM +0800, shh@gmail.com wrote: > From: Shaohui Xie > > This commit adds necessary definitions for the PHY layer to recognize > backplane Ethernet 1000BASE-KX and 10GBASE-KR as valid PHY interfaces, > "1000base-kx" for 1000BASE-KX, "10gbase-kr" for 10GBASE-KR. >

[PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-14 Thread shh.xie
From: Shaohui Xie This commit adds necessary definitions for the PHY layer to recognize backplane Ethernet 1000BASE-KX and 10GBASE-KR as valid PHY interfaces, "1000base-kx" for 1000BASE-KX, "10gbase-kr" for 10GBASE-KR. Signed-off-by: Shaohui Xie --- changes in v2: new patch. Documentation/dev