Re: [PATCH 1/2 v3] Driver for Freescale 8610 and 5121 DIU

2008-03-27 Thread Andrew Morton
On Tue, 25 Mar 2008 16:27:17 -0500 York Sun <[EMAIL PROTECTED]> wrote: > +#if defined(CONFIG_NOT_COHERENT_CACHE) > +unsigned int *coherence_data; > +phys_addr_t *coherence_data_phy; > +#endif These identifiers are too general for use as global symbols. I'd suggest renaming them to diu_coherence_

Re: [PATCH 1/2 v3] Driver for Freescale 8610 and 5121 DIU

2008-03-25 Thread Scott Wood
York Sun wrote: +Example (MPC8610HPCD) + [EMAIL PROTECTED] { [EMAIL PROTECTED] + device_type = "lcd"; No device_type. + compatible = "fsl-diu"; "fsl,diu". +s) Freescale on board FPGA + +This is the memory-mapped registers for on board FPGA

[PATCH 1/2 v3] Driver for Freescale 8610 and 5121 DIU

2008-03-25 Thread York Sun
The following features are supported: plane 0 works as a regular frame buffer, can be accessed by /dev/fb0 plane 1 has two AOIs (area of interest), can be accessed by /dev/fb1 and /dev/fb2 plane 2 has two AOIs, can be accessed by /dev/fb3 and /dev/fb4 Special ioctls support AOIs All /dev/fb* can