Re: [PATCH 1/2] usb: Remove broken optimisation in OHCI IRQ handler

2007-12-06 Thread David Brownell
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Subject: [PATCH 1/2] usb: Remove broken optimisation in OHCI IRQ handler The OHCI IRQ handler has an optimisation that avoids reading some chip registers when the controller reports that the interrupt was triggered *only* because completed re

Re: [PATCH 1/2] usb: Remove broken optimisation in OHCI IRQ handler

2007-12-06 Thread David Brownell
On Sunday 25 November 2007, Benjamin Herrenschmidt wrote: > While there, any reason why we do the read of the interenable register > and mask ? Is that actually useful in practice ? I haven't removed it > but it might be a good candidate if we want to save on MMIO reads. The code uses that registe

[PATCH 1/2] usb: Remove broken optimisation in OHCI IRQ handler

2007-11-25 Thread Benjamin Herrenschmidt
The OHCI IRQ handler has an optimisation that tries to avoid reading the status register when it sees something has been put in the controller "done list". This optimisation is broken on controllers that use edge interrupt signaling as it relies on "missed" interrupt to be re-emitted which is not