Re: [kernel-hardening] Re: [PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-24 Thread Michael Ellerman
On 24 February 2017 6:32:13 pm AEDT, Bhupesh Sharma wrote: >Hi Michael, > >On Thu, Feb 16, 2017 at 10:19 AM, Bhupesh Sharma >wrote: >> Hi Michael, >> >> On Fri, Feb 10, 2017 at 4:41 PM, Bhupesh Sharma >wrote: >>> On Fri, Feb 10, 2017 at 4:31 PM, Michael Ellerman > wrote: Bhupesh Sharma w

Re: [kernel-hardening] Re: [PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-23 Thread Bhupesh Sharma
Hi Michael, On Thu, Feb 16, 2017 at 10:19 AM, Bhupesh Sharma wrote: > Hi Michael, > > On Fri, Feb 10, 2017 at 4:41 PM, Bhupesh Sharma wrote: >> On Fri, Feb 10, 2017 at 4:31 PM, Michael Ellerman >> wrote: >>> Bhupesh Sharma writes: >>> HI Michael, On Thu, Feb 2, 2017 at 3:53 PM,

Re: [kernel-hardening] Re: [PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-15 Thread Bhupesh Sharma
Hi Michael, On Fri, Feb 10, 2017 at 4:41 PM, Bhupesh Sharma wrote: > On Fri, Feb 10, 2017 at 4:31 PM, Michael Ellerman wrote: >> Bhupesh Sharma writes: >> >>> HI Michael, >>> >>> On Thu, Feb 2, 2017 at 3:53 PM, Michael Ellerman >>> wrote: Bhupesh Sharma writes: > powerpc: arch_

Re: [kernel-hardening] Re: [PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-10 Thread Bhupesh Sharma
On Fri, Feb 10, 2017 at 4:31 PM, Michael Ellerman wrote: > Bhupesh Sharma writes: > >> HI Michael, >> >> On Thu, Feb 2, 2017 at 3:53 PM, Michael Ellerman wrote: >>> Bhupesh Sharma writes: >>> powerpc: arch_mmap_rnd() uses hard-coded values, (23-PAGE_SHIFT) for 32-bit and (30-PAGE_SHIF

Re: [kernel-hardening] Re: [PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-10 Thread Michael Ellerman
Bhupesh Sharma writes: > HI Michael, > > On Thu, Feb 2, 2017 at 3:53 PM, Michael Ellerman wrote: >> Bhupesh Sharma writes: >> >>> powerpc: arch_mmap_rnd() uses hard-coded values, (23-PAGE_SHIFT) for >>> 32-bit and (30-PAGE_SHIFT) for 64-bit, to generate the random offset >>> for the mmap base a

Re: [PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-08 Thread Bhupesh Sharma
HI Michael, On Thu, Feb 2, 2017 at 3:53 PM, Michael Ellerman wrote: > Bhupesh Sharma writes: > >> powerpc: arch_mmap_rnd() uses hard-coded values, (23-PAGE_SHIFT) for >> 32-bit and (30-PAGE_SHIFT) for 64-bit, to generate the random offset >> for the mmap base address. >> >> This value represents

Re: [kernel-hardening] Re: [PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-02 Thread Michael Ellerman
Balbir Singh writes: > On Thu, Feb 02, 2017 at 09:23:33PM +1100, Michael Ellerman wrote: >> +config ARCH_MMAP_RND_BITS_MIN >> +# On 64-bit up to 1G of address space (2^30) >> +default 12 if 64BIT && PPC_256K_PAGES # 256K (2^18), = 30 - 18 = 12 >> +default 14 if 64BIT && PPC_64K_PAGE

Re: [PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-02 Thread Bhupesh Sharma
HI Balbir, On Thu, Feb 2, 2017 at 2:41 PM, Balbir Singh wrote: >> @@ -100,6 +132,8 @@ config PPC >> select HAVE_EFFICIENT_UNALIGNED_ACCESS if !(CPU_LITTLE_ENDIAN && >> POWER7_CPU) >> select HAVE_KPROBES >> select HAVE_ARCH_KGDB >> + select HAVE_ARCH_MMAP_RND_BITS >> + s

Re: [PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-02 Thread Bhupesh Sharma
Hi Kees, On Thu, Feb 2, 2017 at 7:55 PM, Kees Cook wrote: > On Wed, Feb 1, 2017 at 9:42 PM, Bhupesh Sharma wrote: >> powerpc: arch_mmap_rnd() uses hard-coded values, (23-PAGE_SHIFT) for >> 32-bit and (30-PAGE_SHIFT) for 64-bit, to generate the random offset >> for the mmap base address. >> >> Th

Re: [PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-02 Thread Kees Cook
On Wed, Feb 1, 2017 at 9:42 PM, Bhupesh Sharma wrote: > powerpc: arch_mmap_rnd() uses hard-coded values, (23-PAGE_SHIFT) for > 32-bit and (30-PAGE_SHIFT) for 64-bit, to generate the random offset > for the mmap base address. > > This value represents a compromise between increased > ASLR effective

Re: [PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-02 Thread Balbir Singh
On Thu, Feb 02, 2017 at 09:23:33PM +1100, Michael Ellerman wrote: > +config ARCH_MMAP_RND_BITS_MIN > + # On 64-bit up to 1G of address space (2^30) > + default 12 if 64BIT && PPC_256K_PAGES # 256K (2^18), = 30 - 18 = 12 > + default 14 if 64BIT && PPC_64K_PAGES# 64K (2^16), = 30 -

Re: [PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-02 Thread Michael Ellerman
Bhupesh Sharma writes: > powerpc: arch_mmap_rnd() uses hard-coded values, (23-PAGE_SHIFT) for > 32-bit and (30-PAGE_SHIFT) for 64-bit, to generate the random offset > for the mmap base address. > > This value represents a compromise between increased > ASLR effectiveness and avoiding address-spac

Re: [PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-02 Thread Balbir Singh
> @@ -100,6 +132,8 @@ config PPC > select HAVE_EFFICIENT_UNALIGNED_ACCESS if !(CPU_LITTLE_ENDIAN && > POWER7_CPU) > select HAVE_KPROBES > select HAVE_ARCH_KGDB > + select HAVE_ARCH_MMAP_RND_BITS > + select HAVE_ARCH_MMAP_RND_COMPAT_BITS if COMPAT COMPAT is on for ppc64 b

[PATCH 1/2] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-02-01 Thread Bhupesh Sharma
powerpc: arch_mmap_rnd() uses hard-coded values, (23-PAGE_SHIFT) for 32-bit and (30-PAGE_SHIFT) for 64-bit, to generate the random offset for the mmap base address. This value represents a compromise between increased ASLR effectiveness and avoiding address-space fragmentation. Replace it with a K