Ben
Will these two patches be pushed upstream or are they waiting for
review/test ?
They fix a hang that we get with some perf events.
Thanks,
Sukadev
Michael Neuling [mi...@neuling.org] wrote:
| If a PMC is about to overflow on a counter that's on an active perf event
| (ie. less than 256 fr
On 11/06/2012 03:49 PM, Michael Neuling wrote:
>>
>>
>> I have couple of questions.
>>
>> Can the buggy overflow happen on any of the available counters PMC1-PMC4 ?
>
> No. It's limited to certain events and I believe it can only happen on
> PMC2 and 4. This code doesn't bother trying to make t
Anshuman Khandual wrote:
> On 11/06/2012 07:23 AM, Michael Neuling wrote:
>
> > + if (!found && pvr_version_is(PVR_POWER7)) {
> > + /* check active counters for special buggy p7 overflow */
> > + for (i = 0; i < cpuhw->n_events; ++i) {
> > + event = cpuhw-
On 11/06/2012 07:23 AM, Michael Neuling wrote:
> + if (!found && pvr_version_is(PVR_POWER7)) {
> + /* check active counters for special buggy p7 overflow */
> + for (i = 0; i < cpuhw->n_events; ++i) {
> + event = cpuhw->event[i];
> +
If a PMC is about to overflow on a counter that's on an active perf event
(ie. less than 256 from the end) and a _different_ PMC overflows just at this
time (a PMC that's not on an active perf event), we currently mark the event as
found, but in reality it's not as it's likely the other PMC that ca
> Thanks for looking into this mess. One small thing we can fix in a
> follow up patch:
> > + if (!found)
> > + printk(KERN_WARNING "Can't find PMC that caused
>
> I think it would be worth making that a printk_ratelimited. We are
> probably dead at this stage but we shouldn't spam the
Hi,
Thanks for looking into this mess. One small thing we can fix in a
follow up patch:
> + if (!found)
> + printk(KERN_WARNING "Can't find PMC that caused
I think it would be worth making that a printk_ratelimited. We are
probably dead at this stage but we shouldn't spam the co
If a PMC is about to overflow on a counter that's on an active perf event
(ie. less than 256 from the end) and a _different_ PMC overflows just at this
time (a PMC that's not on an active perf event), we currently mark the event as
found, but in reality it's not as it's likely the other PMC that ca
