Re: [PATCH 1/2] powerpc/papr_scm: Fetch nvdimm performance stats from PHYP

2020-06-24 Thread Ira Weiny
On Wed, Jun 24, 2020 at 08:28:57PM +0530, Vaibhav Jain wrote: > Thanks for reviewing this patch Ira, > > My responses below inline. > > Ira Weiny writes: > > > On Mon, Jun 22, 2020 at 09:54:50AM +0530, Vaibhav Jain wrote: > >> Update papr_scm.c to query dimm performance statistics from PHYP via

Re: [PATCH 1/2] powerpc/papr_scm: Fetch nvdimm performance stats from PHYP

2020-06-23 Thread Ira Weiny
On Mon, Jun 22, 2020 at 09:54:50AM +0530, Vaibhav Jain wrote: > Update papr_scm.c to query dimm performance statistics from PHYP via > H_SCM_PERFORMANCE_STATS hcall and export them to user-space as PAPR > specific NVDIMM attribute 'perf_stats' in sysfs. The patch also > provide a sysfs ABI document

Re: [PATCH 1/2] powerpc/papr_scm: Fetch nvdimm performance stats from PHYP

2020-06-22 Thread Aneesh Kumar K.V
Aneesh Kumar K.V writes: > Vaibhav Jain writes: > + */ >> +seq_buf_init(&s, buf, PAGE_SIZE); >> +for (index = 0, stat = stats->scm_statistic; >> + index < stats->num_statistics; ++index, ++stat) { >> +seq_buf_printf(&s, "%.

Re: [PATCH 1/2] powerpc/papr_scm: Fetch nvdimm performance stats from PHYP

2020-06-22 Thread Aneesh Kumar K.V
Vaibhav Jain writes: > Update papr_scm.c to query dimm performance statistics from PHYP via > H_SCM_PERFORMANCE_STATS hcall and export them to user-space as PAPR > specific NVDIMM attribute 'perf_stats' in sysfs. The patch also > provide a sysfs ABI documentation for the stats being reported and

[PATCH 1/2] powerpc/papr_scm: Fetch nvdimm performance stats from PHYP

2020-06-21 Thread Vaibhav Jain
Update papr_scm.c to query dimm performance statistics from PHYP via H_SCM_PERFORMANCE_STATS hcall and export them to user-space as PAPR specific NVDIMM attribute 'perf_stats' in sysfs. The patch also provide a sysfs ABI documentation for the stats being reported and their meanings. During NVDIMM