Re: [PATCH 1/2] perf annotate: generalize handling of ret instructions

2016-06-10 Thread Naveen N. Rao
On 2016/06/10 10:30AM, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 10, 2016 at 06:32:50PM +0530, Naveen N. Rao escreveu: > > Introduce helper to detect ret instructions and use the same in the tui. Hi Arnaldo, Thanks for the review. > > Humm, I think this is simpler and equivalent, since so fa

Re: [PATCH 1/2] perf annotate: generalize handling of ret instructions

2016-06-10 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 10, 2016 at 06:32:50PM +0530, Naveen N. Rao escreveu: > Introduce helper to detect ret instructions and use the same in the tui. Humm, I think this is simpler and equivalent, since so far we didn't had any need for special handling of "retq"/"ret" instructions: diff --git a/tools/perf

[PATCH 1/2] perf annotate: generalize handling of ret instructions

2016-06-10 Thread Naveen N. Rao
Introduce helper to detect ret instructions and use the same in the tui. Cc: Arnaldo Carvalho de Melo Cc: Anton Blanchard Cc: Michael Ellerman Cc: Ananth N Mavinakayanahalli Signed-off-by: Naveen N. Rao --- tools/perf/ui/browsers/annotate.c | 20 +--- tools/perf/util/annotate