Re: [PATCH 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-10-16 Thread Aneesh Kumar K.V
Steve Capper writes: > Can we not just add a: > #define pgd_huge(pgd) (0) > above the "#endif /* CONFIG_HUGETLB_PAGE */" line in the second patch? > (or, more precisely, prevent the second patch from removing this line). > > That way we get a clearer code overall? it is strange to have b

Re: [PATCH 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-10-16 Thread Steve Capper
On Thu, Oct 16, 2014 at 08:48:20PM +0530, Aneesh Kumar K.V wrote: > Steve Capper writes: > > > On Wed, Oct 15, 2014 at 10:04:47PM +0530, Aneesh Kumar K.V wrote: > >> Update generic gup implementation with powerpc specific details. > >> On powerpc at pmd level we can have hugepte, normal pmd point

Re: [PATCH 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-10-16 Thread Aneesh Kumar K.V
Steve Capper writes: > On Wed, Oct 15, 2014 at 10:04:47PM +0530, Aneesh Kumar K.V wrote: >> Update generic gup implementation with powerpc specific details. >> On powerpc at pmd level we can have hugepte, normal pmd pointer >> or a pointer to the hugepage directory. >> >> Signed-off-by: Aneesh K

Re: [PATCH 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-10-16 Thread Steve Capper
On Wed, Oct 15, 2014 at 10:04:47PM +0530, Aneesh Kumar K.V wrote: > Update generic gup implementation with powerpc specific details. > On powerpc at pmd level we can have hugepte, normal pmd pointer > or a pointer to the hugepage directory. > > Signed-off-by: Aneesh Kumar K.V Hi, This patch caus

[PATCH 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-10-15 Thread Aneesh Kumar K.V
Update generic gup implementation with powerpc specific details. On powerpc at pmd level we can have hugepte, normal pmd pointer or a pointer to the hugepage directory. Signed-off-by: Aneesh Kumar K.V --- include/linux/hugetlb.h | 1 + include/linux/mm.h | 26 +++ mm/gup.c