On Tue, Jun 17, 2008 at 05:03:13PM -0600, John Rigby wrote:
> static int __devinit find_phy(struct device_node *np,
> - struct fs_platform_info *fpi)
> + struct fs_platform_info *fpi)
Please don't make this sort of change. Spaces were used d
On Jun 17, 2008, at 11:12 PM, John Rigby wrote:
Sorry, I thought I was doing the right thing to base the patch on
Kumar's patch that removes the CONFIG_PPC_CPM_NEW_BINDING stuff.
That is likely why it did not apply.
It is the right thing, we just need to work out the logistics here.
Je
I agree, I'll separate the fec_t -> struct fec changes out.
On Tue, Jun 17, 2008 at 11:20 PM, Grant Likely <[EMAIL PROTECTED]>
wrote:
> On Tue, Jun 17, 2008 at 5:03 PM, John Rigby <[EMAIL PROTECTED]> wrote:
> > Fixed all errors and warnings that checkpatch.pl
> > reports if this was a new submiss
On Tue, Jun 17, 2008 at 5:03 PM, John Rigby <[EMAIL PROTECTED]> wrote:
> Fixed all errors and warnings that checkpatch.pl
> reports if this was a new submission.
> Also changed instances of fec_t to struct fec in
> mac-fec.c and mii-fec.c.
Nit: checkpatch is not law; particularly in the case of wh
Sorry, I thought I was doing the right thing to base the patch on Kumar's
patch that removes the CONFIG_PPC_CPM_NEW_BINDING stuff. That is likely why
it did not apply.
On Tue, Jun 17, 2008 at 9:54 PM, Jeff Garzik <[EMAIL PROTECTED]> wrote:
> John Rigby wrote:
>
>> Fixed all errors and warnings t
John Rigby wrote:
Fixed all errors and warnings that checkpatch.pl
reports if this was a new submission.
Also changed instances of fec_t to struct fec in
mac-fec.c and mii-fec.c.
This is in preparation of adding MPC5121 support.
Signed-off-by: John Rigby <[EMAIL PROTECTED]>
---
drivers/net/fs_
Fixed all errors and warnings that checkpatch.pl
reports if this was a new submission.
Also changed instances of fec_t to struct fec in
mac-fec.c and mii-fec.c.
This is in preparation of adding MPC5121 support.
Signed-off-by: John Rigby <[EMAIL PROTECTED]>
---
drivers/net/fs_enet/fs_enet-main.c