Re: [PATCH 1/2] eeh: Fixing a bug when pci structure is null

2010-01-28 Thread Benjamin Herrenschmidt
On Wed, 2010-01-27 at 12:43 -0600, lei...@linux.vnet.ibm.com wrote: > diff --git a/arch/powerpc/platforms/pseries/eeh_driver.c > b/arch/powerpc/platforms/pseries/eeh_driver.c > index ef8e454..afdddf6 100644 > --- a/arch/powerpc/platforms/pseries/eeh_driver.c > +++ b/arch/powerpc/platforms/pseries

Re: [PATCH 1/2] eeh: Fixing a bug when pci structure is null

2010-01-27 Thread Linas Vepstas
Hi, Yes, that's really my sign off: I discussed this at length with Breno. One comment: 2010/1/27 : > During a EEH recover, the pci_dev structure can be null, It can be null when an error is detected during device config (i.e. via pci config space access through open firmware, using the OF devi

[PATCH 1/2] eeh: Fixing a bug when pci structure is null

2010-01-27 Thread leitao
During a EEH recover, the pci_dev structure can be null, and currently the kernel is crashing when pci_dev is null, with the following message: Unable to handle kernel paging request for data at address 0x00a0 Faulting instruction address: 0xc006b8b4 Oops: Kernel access of bad area, si