RE: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c

2010-09-24 Thread Tirumala Marri
> > It would be really preferable to support all those platforms in a > single Linux > image. If technically possible, please try to move this direction. It is do-able for couple of SoCs. Other SoC DMA engines are quite a bit different. Let me first do small steps first and slowly achieve some run

Re: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c

2010-09-23 Thread Stefan Roese
On Friday 24 September 2010 00:39:47 Tirumala Marri wrote: > > Will both versions of this driver exist in the same kernel build? For > > example the iop-adma driver supports iop13xx and iop3xx, but we select > > the archtitecture at build time? Or, as I assume in this case, will > > the > > two (

RE: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c

2010-09-23 Thread Tirumala Marri
> > Will both versions of this driver exist in the same kernel build? For > example the iop-adma driver supports iop13xx and iop3xx, but we select > the archtitecture at build time? Or, as I assume in this case, will > the > two (maybe more?) ppc4xx adma drivers all be built in the same image, >

Re: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c

2010-09-23 Thread Dan Williams
On 9/17/2010 6:42 PM, tma...@apm.com wrote: From: Tirumala Marri This patch generalizes the existing drver/dma/ppc4xx/adma.c, so that common code can be shared between different similar DMA engine drivers in other SoCs. Signed-off-by: Tirumala R Marri --- drivers/dma/ppc4xx/adma.c| 43

RE: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c

2010-09-21 Thread Tirumala Marri
e: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c > > Hi Tirumala, > > > drivers/dma/ppc4xx/adma.c| 4370 +++- > -- > > drivers/dma/ppc4xx/adma.h| 116 +- > > drivers/dma/ppc4xx/ppc4xx-adma.h | 4020 > ++

Re: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c

2010-09-20 Thread Wolfgang Denk
Dear Tirumala Marri, In message <7707889dee57e97ad50b4ce5c7697...@mail.gmail.com> you wrote: > > > > +/** > > > + * ppc440spe_can_rxor - check if the operands may be processed with RXOR > > > + */ > > > +static int ppc440spe_can_rxor(struct page **srcs, int src_cnt, > > size_t len) > > > > Again,

RE: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c

2010-09-20 Thread Tirumala Marri
Mr. Wolfgang > > Will this driver ever include any 40x processors? If not, you probably > should use "44x" instead (here and everywhere in the rest of the > code). [Marri] Yes there is 40x based DMA engine we planned to include in the future. > > +/* Pointer to DMA0, DMA1 CP/CS FIFO */ > > +static

Re: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c

2010-09-19 Thread Ilya Yanok
Hi Tirumala, > drivers/dma/ppc4xx/adma.c| 4370 > +++--- > drivers/dma/ppc4xx/adma.h| 116 +- > drivers/dma/ppc4xx/ppc4xx-adma.h | 4020 +++ You've moved tons of code to the header file. Why? Regards, Ilya. _

Re: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c

2010-09-18 Thread Wolfgang Denk
Dear tma...@apm.com, In message <1284774145-14543-1-git-send-email-tma...@apm.com> you wrote: > > This patch generalizes the existing drver/dma/ppc4xx/adma.c, so that > common code can be shared between different similar DMA engine > drivers in other SoCs. ... > * This driver supports the async