Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-14 Thread Deepthi Dharwar
On 02/14/2014 04:47 PM, Preeti U Murthy wrote: > Hi Nicolas, > > You will have to include the below patch with yours. You > could squash the two I guess, I have added the changelog > just for clarity. And you also might want to change the subject to > cpuidle/powernv. It gives a better picture. >

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-14 Thread Preeti U Murthy
Hi Nicolas, You will have to include the below patch with yours. You could squash the two I guess, I have added the changelog just for clarity. And you also might want to change the subject to cpuidle/powernv. It gives a better picture. Thanks Regards Preeti U Murthy cpuidle/powernv: Add ppc64

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-09 Thread Preeti U Murthy
Hi Peter, On 02/07/2014 06:11 PM, Peter Zijlstra wrote: > On Fri, Feb 07, 2014 at 05:11:26PM +0530, Preeti U Murthy wrote: >> But observe the idle state "snooze" on powerpc. The power that this idle >> state saves is through the lowering of the thread priority of the CPU. >> After it lowers the th

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-07 Thread Peter Zijlstra
On Fri, Feb 07, 2014 at 05:11:26PM +0530, Preeti U Murthy wrote: > But observe the idle state "snooze" on powerpc. The power that this idle > state saves is through the lowering of the thread priority of the CPU. > After it lowers the thread priority, it is done. It cannot > "wait_for_interrupts".

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-07 Thread Preeti U Murthy
Hi Nicolas, On 02/07/2014 04:18 PM, Nicolas Pitre wrote: > On Fri, 7 Feb 2014, Preeti U Murthy wrote: > >> Hi Nicolas, >> >> On 02/07/2014 06:47 AM, Nicolas Pitre wrote: >>> >>> What about creating arch_cpu_idle_enter() and arch_cpu_idle_exit() in >>> arch/powerpc/kernel/idle.c and calling ppc64

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-07 Thread Preeti U Murthy
Hi Deepthi, On 02/07/2014 03:15 PM, Deepthi Dharwar wrote: > Hi Preeti, > > Thanks for the patch. > > On 02/07/2014 12:31 PM, Preeti U Murthy wrote: >> Hi Nicolas, >> >> Find below the patch that will need to be squashed with this one. >> This patch is based on the mainline.Adding Deepthi, the a

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-07 Thread Nicolas Pitre
On Fri, 7 Feb 2014, Preeti U Murthy wrote: > Hi Nicolas, > > On 02/07/2014 06:47 AM, Nicolas Pitre wrote: > > > > What about creating arch_cpu_idle_enter() and arch_cpu_idle_exit() in > > arch/powerpc/kernel/idle.c and calling ppc64_runlatch_off() and > > ppc64_runlatch_on() respectively from

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-07 Thread Deepthi Dharwar
Hi Preeti, Thanks for the patch. On 02/07/2014 12:31 PM, Preeti U Murthy wrote: > Hi Nicolas, > > Find below the patch that will need to be squashed with this one. > This patch is based on the mainline.Adding Deepthi, the author of > the patch which introduced the powernv cpuidle driver. Deepthi

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
Hi Nicolas, Find below the patch that will need to be squashed with this one. This patch is based on the mainline.Adding Deepthi, the author of the patch which introduced the powernv cpuidle driver. Deepthi, do you think the below patch looks right? We do not need to do an explicit local_irq_enabl

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
Hi Nicolas, On 02/07/2014 06:47 AM, Nicolas Pitre wrote: > On Thu, 6 Feb 2014, Preeti U Murthy wrote: > >> Hi Daniel, >> >> On 02/06/2014 09:55 PM, Daniel Lezcano wrote: >>> Hi Nico, >>> >>> >>> On 6 February 2014 14:16, Nicolas Pitre wrote: >>> The core idle loop now takes care of it.

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Nicolas Pitre
On Thu, 6 Feb 2014, Preeti U Murthy wrote: > Hi Daniel, > > On 02/06/2014 09:55 PM, Daniel Lezcano wrote: > > Hi Nico, > > > > > > On 6 February 2014 14:16, Nicolas Pitre wrote: > > > >> The core idle loop now takes care of it. > >> > >> Signed-off-by: Nicolas Pitre > >> --- > >> arch/power

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Daniel Lezcano
Hi Nico, On 6 February 2014 14:16, Nicolas Pitre wrote: > The core idle loop now takes care of it. > > Signed-off-by: Nicolas Pitre > --- > arch/powerpc/platforms/powernv/setup.c | 13 + > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/arch/powerpc/platforms/powe

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
Hi Daniel, On 02/06/2014 09:55 PM, Daniel Lezcano wrote: > Hi Nico, > > > On 6 February 2014 14:16, Nicolas Pitre wrote: > >> The core idle loop now takes care of it. >> >> Signed-off-by: Nicolas Pitre >> --- >> arch/powerpc/platforms/powernv/setup.c | 13 + >> 1 file changed, 1

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
On 02/06/2014 07:46 PM, Nicolas Pitre wrote: > The core idle loop now takes care of it. > > Signed-off-by: Nicolas Pitre > --- > arch/powerpc/platforms/powernv/setup.c | 13 + > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/setup.c

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Thomas Gleixner
An Thu, 6 Feb 2014, Nicolas Pitre wrote: > The core idle loop now takes care of it. > > Signed-off-by: Nicolas Pitre Acked-by: Thomas Gleixner ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Nicolas Pitre
The core idle loop now takes care of it. Signed-off-by: Nicolas Pitre --- arch/powerpc/platforms/powernv/setup.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c index 21166f65c9..a9