On Fri, Jul 13, 2007 at 12:12:33PM +0200, Christoph Hellwig wrote:
> > -static inline int spu_stopped(struct spu_context *ctx, u32 * stat)
> > +static inline int spu_stopped(struct spu_context *ctx, u32 *stat)
>
> useless (and wrong) reformatting, please remove.
Sorry, this looked like going the
On Fri, Jul 13, 2007 at 10:34:50PM +1000, Benjamin Herrenschmidt wrote:
>
> > > + if (unlikely(test_bit(SPU_SCHED_NOTIFY_ACTIVE,
> > > + &ctx->sched_flags))) {
> > > + clear_bit(SPU_SCHED_NOTIFY_ACTIVE, &ctx->sched_flags);
> >
> > this should
> > + if (unlikely(test_bit(SPU_SCHED_NOTIFY_ACTIVE,
> > + &ctx->sched_flags))) {
> > + clear_bit(SPU_SCHED_NOTIFY_ACTIVE, &ctx->sched_flags);
>
> this should use test_and_clear_bit
This also looks like an abuse of atomics to effectivel
On Fri, Jul 13, 2007 at 12:12:33PM +0200, Christoph Hellwig wrote:
> On Thu, Jul 12, 2007 at 06:45:40PM -0500, Bob Nelson wrote:
> > We would like this patch included in -mm and in 2.6.23.
>
> Do you plan to submit oprofile support aswell? In that case it's fine
> otherwise please send it togethe
On Thu, Jul 12, 2007 at 06:45:40PM -0500, Bob Nelson wrote:
> We would like this patch included in -mm and in 2.6.23.
Do you plan to submit oprofile support aswell? In that case it's fine
otherwise please send it together with the actual oprofile support.
> +static void notify_spus_active(void)
We would like this patch included in -mm and in 2.6.23.
Subject: Enable SPU switch notification to detect currently active SPU
tasks.
From: Maynard Johnson <[EMAIL PROTECTED]>
This patch adds to the capability of spu_switch_event_register so that
the
caller is also notified of currently active S
